Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <002b72cab9896fa5ac76a52e0cb503ff@kernel.org> <20200319023448.1479701-1-mans0n@gorani.run>
In-Reply-To: <20200319023448.1479701-1-mans0n@gorani.run>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 27 Mar 2020 11:28:38 +0100
Message-ID: <CACRpkdZZN9hfZ7ARRd+JbFKjfXDMa_M3wqYD1gPqUCiTpp=LNA@mail.gmail.com>
Subject: Re: [PATCH v2] irqchip/versatile-fpga: Handle chained IRQs properly
To:     Sungbo Eo <mans0n@gorani.run>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <maz@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-oxnas@groups.io, Neil Armstrong <narmstrong@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 19, 2020 at 3:36 AM Sungbo Eo <mans0n@gorani.run> wrote:

> Enclose the chained handler with chained_irq_{enter,exit}(), so that the
> muxed interrupts get properly acked.
>
> This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer
> interrupt is never acked. The kernel waits a clock tick forever in
> calibrate_delay_converge(), which leads to a boot hang.
>
> Fixes: c41b16f8c9d9 ("ARM: integrator/versatile: consolidate FPGA IRQ handling code")
> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> ---
> v2: moved readl below chained_irq_enter()
>     added Fixes tag

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I wonder how Integrator keeps working so well despite
this. I can't test it right now but I'm sure it is fine.

Yours,
Linus Walleij