Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2439515ybb; Fri, 27 Mar 2020 05:40:57 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuu4kvoOTArzhu1w9Dlh/IkcfvxLtgv4x8tsybXHqRGlu0ShXIHjesVihGvhGgWCoyp11BR X-Received: by 2002:a05:6830:4025:: with SMTP id i5mr10608714ots.203.1585312857191; Fri, 27 Mar 2020 05:40:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585312857; cv=none; d=google.com; s=arc-20160816; b=z58+oQSrO4s97PND1DhRekBQ4vPAr0JrGrZ3Gstcg8pPG3kTvnzRnBaBs/BmZdNhfs iY/ZyCY3k3UfUNBzxcq/bst9LB/F+ZAax8T5ZI/TfZSt2mysxJnS/lRIZJgyc2pUr+Xk 14DqiJOKMdBKnJ96a9MJvmDVhTKcYuRRiJ04gOxrOuae6yJBpf2VZeE6lNFxoVT/DkPZ D4/Qy8gWUUhV3/yP4/pQvYyZLmS9wLhbfkD3YeBTzPlrx8UJwkNPb9kJJLFRELSNcnI4 X6qCJIEY2oXV8WOMCb//zYJwqJxsqywbePo06byQgxQZOCYyp4G51zjzI0dhtPwI+TW8 coOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=jZHFiWax8vCvFZJl+Fo54qpkUa4Crpp6F75KMLPAOl8=; b=OX2Zq5SMlCWxKE95IUGL12rOqPOqoxwegcaUvXarz5/NgoHcXNeh0DrHo2jtSxshiv CG4nSOM1m04F9gUsWzU5HCJx1MHYYAe2aN2IcmRywyFNbavzu0C/TnmxunE+MCkU6dhC ZfeUmgjXay4YXf2NmFoGnViP6FOvLjw7uwOzd302rVNdDpmnFuEZ2/Q49Ii8aoHpYGtZ tMKwDsyUj/asNAA3/NIBPMxi71PUCYanElpEx/HzE/z75bf4/SZDDXtLQAb7UYqXNDAp Hy0+uH80+vSqzULRkvz3x2wnB0Widd6RA7J/0zjGbK/SYh3ZvkzQLzBRhBgJ391f0QSu 3+zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gSh1gE1Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j8si2206119oib.260.2020.03.27.05.40.44; Fri, 27 Mar 2020 05:40:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gSh1gE1Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbgC0MkL (ORCPT + 99 others); Fri, 27 Mar 2020 08:40:11 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40293 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbgC0MkK (ORCPT ); Fri, 27 Mar 2020 08:40:10 -0400 Received: by mail-wr1-f66.google.com with SMTP id u10so11220071wro.7; Fri, 27 Mar 2020 05:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jZHFiWax8vCvFZJl+Fo54qpkUa4Crpp6F75KMLPAOl8=; b=gSh1gE1Yz3lU4ivwfNB+k/+ydo1wN4UNR3yIdL5Ae311j2ZRONhSmKEL4Ky00zVO6B p0vDv3LMBMBcX+xF5JsE9FFLEdyuayAuxuq0YpBOgAmb3raaqn7Z8whvwmG9vrtg69Sw JVrflaT1O86knx4zu6XIU0Eejx4mYm0i972UKLIL5VLuZXn8iDwOYswPEm8ujRc18Gem xh/lXLvIGELQEAt8HWpSbDCq3Hg0FdLZTIL8+ioEaz1HZFt2on+nOGfEP9waji/lI16u 4MrrS89SWr5I8WQSRdQhEJlofDB46HDpTZksPP+H3HyWxr39RjXJM+14IMsqgzjwNtsl wbqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jZHFiWax8vCvFZJl+Fo54qpkUa4Crpp6F75KMLPAOl8=; b=hL/ey5hkDXc9vilE5RKInTrY1OmAai/Dvpyt7deZpbb7UIZpvSzWk0k3pPQIja3qZq xJcVLCXd87sMXmkYHgKlOdPRdUlv8r30+nQ4q08vY8DfBjblR72i6A7JZOOGWnKaD2P2 I40TVky28tfoL++YazOXfhDuYOqTcunWr8qXzk8ojV9fKfy5lrhWX0IZnhM0dzbIgT32 tu9G3Mha8he8sgVc4qqTt6X/xcNc3g+b2OMedx1A+XuUH97dvivD3FQOVMNWWTtfoBZj EYE1/NJZjF6b7chGPXCMulk/96R8R20/OXhun8genCNX/FbLZ1YEjV1skISDoQiU0V6X gPnA== X-Gm-Message-State: ANhLgQ1gExEibaFXYCZB1xTCkg9p5N+CVZ5EvqA3b4DCuu8nKAomUwTU liguFai9tfkTeDA/7jJkHIQ= X-Received: by 2002:adf:ab12:: with SMTP id q18mr15276713wrc.148.1585312808970; Fri, 27 Mar 2020 05:40:08 -0700 (PDT) Received: from [192.168.0.104] (p5B3F6E13.dip0.t-ipconnect.de. [91.63.110.19]) by smtp.gmail.com with ESMTPSA id u131sm8292883wmg.41.2020.03.27.05.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 05:40:08 -0700 (PDT) Subject: Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger To: Lee Jones Cc: robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org, andriy.shevchenko@linux.intel.com References: <20200322224626.13160-1-sravanhome@gmail.com> <20200322224626.13160-3-sravanhome@gmail.com> <20200327075541.GF603801@dell> <20200327102221.GA3383@dell> <20200327112523.GC3383@dell> From: saravanan sekar Message-ID: <45f68c40-8e50-e0a2-a89a-b5a164d6b75c@gmail.com> Date: Fri, 27 Mar 2020 13:40:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200327112523.GC3383@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Andy On 27/03/20 12:25 pm, Lee Jones wrote: > On Fri, 27 Mar 2020, saravanan sekar wrote: >> On 27/03/20 11:22 am, Lee Jones wrote: >>> Saravanan, Jonathan, >>> >>> On Fri, 27 Mar 2020, saravanan sekar wrote: >>>> On 27/03/20 8:55 am, Lee Jones wrote: >>>>> On Sun, 22 Mar 2020, Saravanan Sekar wrote: >>>>> >>>>>> mp2629 is a highly-integrated switching-mode battery charge management >>>>>> device for single-cell Li-ion or Li-polymer battery. >>>>>> >>>>>> Add MFD core enables chip access for ADC driver for battery readings, >>>>>> and a power supply battery-charger driver >>>>>> >>>>>> Signed-off-by: Saravanan Sekar >>>>>> --- >>>>>> drivers/mfd/Kconfig | 9 +++ >>>>>> drivers/mfd/Makefile | 2 + >>>>>> drivers/mfd/mp2629.c | 116 +++++++++++++++++++++++++++++++++++++ >>>>>> include/linux/mfd/mp2629.h | 22 +++++++ >>>>>> 4 files changed, 149 insertions(+) >>>>>> create mode 100644 drivers/mfd/mp2629.c >>>>>> create mode 100644 include/linux/mfd/mp2629.h > [...] > >>>>>> +#ifndef __MP2629_H__ >>>>>> +#define __MP2629_H__ >>>>>> + >>>>>> +#include >>>>>> + >>>>>> +struct device; >>>>>> +struct regmap; >>>>> Why not just add the includes? >>>> Some more shared enum added in ADC driver >>> Sorry? >> I misunderstood your previous question that you are asking to remove this >> mp2629.h file >> >> "No user here. (Hint: Use forward declaration of struct device instead)" - >> review comments on V1 from Andy Shevchenko. >> So remove the includes > So Andy has reviewed, but you still don't have him on Cc? Sorry one of his hint made me removed him in CC unknowingly. "For the future, hint:         scripts/get_maintainer.pl --git --git-min-percent=67 ..." My fault, added him in CC > How are we meant to continue the discussion? > > As a general rule I'm not a fan of forward declarations. > > I think they should be avoided if at all possible. Ok will add includes >>>>>> +struct mp2629_info { >>>>>> + struct device *dev; >>>>>> + struct regmap *regmap; >>>>>> +}; >>>>>> + >>>>>> +#endif