Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: N6mJ5jQVFmaoeXk8IMWTdHonEVfzBavS3kGzVjRHFyY9vLDwSuYoottRmIFz0M9PqDdwAPONOM
 VTvo6pqyDhJ+O1sWLY8j73PIhXp1tYpza+durdvE/WHjI6UWejjULSb69/8lybnxh6iSdKsg/A
 l5VsiBgNoJepBtvzaPAHJ1c0TrUbNOkB8ujakZmUDuwlfqogWDHdtvIsUq8DRoxm8ZqYZwQs9R
 CE9Zp042pXau6IG5R8yj2etullPYURzCTGT372j4FxybiB3Qxdr7I/UFDRc92wj8UVswgoPuyY
 JCE=
IronPort-SDR: mLbGuIWhr8qHvJEGRs4rGITXzvziN+jYvXMPNxgqaGORCP7VS8sUeq6K/esQ7Ya5CGMEtL1a0p
 QhKXGnBHaLtIdXBRearHR3KfZC66p76yiATCHAQ+PwyMsg0tHj3OulVzXuHvIi3MNLYXFk2/O0
 PjFkrky3JvEk9QP9JheQ3h0iJmxbJ93Vfs93sIDpTmpGkrFCT83SnM/ZPC9lv2QPL0yPXBrKds
 GVEgpuwPOFlbbT5XKeSZLINl9zNhz7B7f+m9D0FBa3hoADIvyiZv4ci2u41JqItwRbFD8OuCEz
 zYA=
Subject: Re: [PATCH v9 52/55] input: touchscreen: atmel_mxt_ts: Added sysfs
 entry for touchscreen status
To:     Dmitry Osipenko <digetx@gmail.com>, <nick@shmanahar.org>,
        <dmitry.torokhov@gmail.com>, <jikos@kernel.org>,
        <benjamin.tissoires@redhat.com>, <bsz@semihalf.com>,
        <rydberg@bitmath.org>
CC:     <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <erosca@de.adit-jv.com>, <Andrew_Gabbasov@mentor.com>
References: <20200325133334.19346-1-jiada_wang@mentor.com>
 <20200325133334.19346-53-jiada_wang@mentor.com>
 <4aeda6f1-25d8-9437-5cd0-560e43dbe081@gmail.com>
From:   "Wang, Jiada" <jiada_wang@mentor.com>
Message-ID: <b9368137-2fdc-558d-c27c-54d56950f7b8@mentor.com>
Date:   Fri, 27 Mar 2020 21:49:14 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <4aeda6f1-25d8-9437-5cd0-560e43dbe081@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dmitry

On 2020/03/26 4:35, Dmitry Osipenko wrote:
> 25.03.2020 16:33, Jiada Wang пишет:
>> From: Naveen Chakka <Naveen.Chakka@in.bosch.com>
>>
>> To know the current communication status of the touch controller during
>> runtime, sysfs interface is added
>>
>> sysfs interface: /sys/class/i2c-dev/i2c-*/device/*/touch_dev_stat
>> Executing the above sysfs interface provides two output values
>>
>> 1)Status of the touch device
>> 	value 0 represents device is inactive
>> 	value 1 represents device is active
>> 2)Error counter
>> 	value represents the number of times device in inactive since last read
> 
> ...
>>   /* Each client has this additional data */
>>   struct mxt_data {
>>   	struct i2c_client *client;
>> @@ -372,6 +380,9 @@ struct mxt_data {
>>   	const char *pcfg_name;
>>   	const char *input_name;
>>   	struct mxt_flash *flash;
> 
>> +	struct work_struct watchdog_work;
>> +	struct timer_list watchdog_timer;
> 
> This should be replaced with a delayed_work.

will replace with delayer_work
> 
>> +	struct mxt_statusinfo mxt_status;
>>   
>>   	/* Cached parameters from object table */
>>   	u16 T5_address;
> 
> ...
>> +static void mxt_watchdog_work(struct work_struct *work)
>> +{
>> +	struct mxt_data *data =
>> +		container_of(work, struct mxt_data, watchdog_work);
>> +	u16 info_buf;
>> +	int ret = 0;
>> +	u8 size = 2;
> 
>> +	if (data->suspended || data->in_bootloader)
>> +		return;
>> +
>> +	ret = __mxt_read_reg(data->client, 0, size, &info_buf);
> 
> Looks like this need to be protected with a lock to not race with the
> suspending / bootloader states.
> 
right, I will add lock in next version

>> +	if (ret) {
>> +		data->mxt_status.error_count++;
>> +		data->mxt_status.dev_status = false;
>> +	} else {
>> +		data->mxt_status.dev_status = true;
>> +	}
>> +}
> 
> ...> @@ -4329,6 +4414,13 @@ static int mxt_probe(struct i2c_client
> *client, const struct i2c_device_id *id)
>>   		msleep(MXT_RESET_TIME);
>>   	}
>>   
>> +	INIT_WORK(&data->watchdog_work, mxt_watchdog_work);
>> +
>> +	/* setup watchdog timer */
>> +	timer_setup(&data->watchdog_timer, mxt_watchdog_timer, 0);
>> +
>> +	mxt_start_wd_timer(data);
> 
> I'd expect it to be optional and opt-in by either using #ifdef
> TOUCHSCREEN_ATMEL_MXT_DEBUG or having a new debugfs option to explicitly
> enable the "watchdog".
> 
Thanks for your suggestion, I will use module_param to enable/disable
watchdog

Thanks,
Jiada