Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: +K1pps45I3Zs/hCWkcqgX9M/NYKvB7izMsqlgluKb1J52nu8QDOOxr7JtIL4EiktRGY/jSOgx3
 47frldgMQIng==
IronPort-SDR: M0nlyFD0lihw3AO/+x8zICyCg/YldWDhWgfuj3Yx4tKTfwpwoROZ9YIsN4Iepai0BKGoonu4o3
 IAuKPuodU7uQ==
Date:   Fri, 27 Mar 2020 15:19:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc:     linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: add debugfs register r/w
 interface
Message-ID: <20200327131901.GW1922688@smile.fi.intel.com>
References: <5e7dfb41.1c69fb81.cc4bb.042f@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e7dfb41.1c69fb81.cc4bb.042f@mx.google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote:
> The debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.
> 
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
> Changelog v1->v2
> * grab a lock to protect driver state
> * add a comma at the end of structure member initialisation
> 
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 7cb9ff3d3e94..381a3fb09858 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {
>  	.attrs = inv_attributes
>  };
>  
> +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
> +				  unsigned int reg,
> +				  unsigned int writeval,
> +				  unsigned int *readval)
> +{
> +	struct inv_mpu6050_state *st = iio_priv(indio_dev);

> +	int ret = 0;

Assignment is redundant, but I think maintainers may update this when applying.

> +
> +	mutex_lock(&st->lock);
> +	if (readval)
> +		ret = regmap_read(st->map, reg, readval);
> +	else
> +		ret = regmap_write(st->map, reg, writeval);
> +	mutex_unlock(&st->lock);
> +
> +	return ret;
> +}
> +
>  static const struct iio_info mpu_info = {
>  	.read_raw = &inv_mpu6050_read_raw,
>  	.write_raw = &inv_mpu6050_write_raw,
>  	.write_raw_get_fmt = &inv_write_raw_get_fmt,
>  	.attrs = &inv_attribute_group,
>  	.validate_trigger = inv_mpu6050_validate_trigger,
> +	.debugfs_reg_access = &inv_mpu6050_reg_access,
>  };
>  
>  /**
> -- 
> 2.23.0.385.gbc12974a89
> 

-- 
With Best Regards,
Andy Shevchenko