Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v9 52/55] input: touchscreen: atmel_mxt_ts: Added sysfs
 entry for touchscreen status
To:     "Wang, Jiada" <jiada_wang@mentor.com>, nick@shmanahar.org,
        dmitry.torokhov@gmail.com, jikos@kernel.org,
        benjamin.tissoires@redhat.com, bsz@semihalf.com,
        rydberg@bitmath.org
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com
References: <20200325133334.19346-1-jiada_wang@mentor.com>
 <20200325133334.19346-53-jiada_wang@mentor.com>
 <4aeda6f1-25d8-9437-5cd0-560e43dbe081@gmail.com>
 <b9368137-2fdc-558d-c27c-54d56950f7b8@mentor.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <5b03bf10-d4f1-fb3d-4561-1097630c195a@gmail.com>
Date:   Fri, 27 Mar 2020 16:37:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <b9368137-2fdc-558d-c27c-54d56950f7b8@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

27.03.2020 15:49, Wang, Jiada пишет:
>>> +static void mxt_watchdog_work(struct work_struct *work)
>>> +{
>>> +    struct mxt_data *data =
>>> +        container_of(work, struct mxt_data, watchdog_work);
>>> +    u16 info_buf;
>>> +    int ret = 0;
>>> +    u8 size = 2;
>>
>>> +    if (data->suspended || data->in_bootloader)
>>> +        return;
>>> +
>>> +    ret = __mxt_read_reg(data->client, 0, size, &info_buf);
>>
>> Looks like this need to be protected with a lock to not race with the
>> suspending / bootloader states.
>>
> right, I will add lock in next version

Alternatively, maybe the watchdog_work could be just stopped in
suspended / bootloader states.