Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2681932ybb; Fri, 27 Mar 2020 10:06:11 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv1sCz8DQdwSMdSDxBZyTmbdSyAT6tcRUxCxDWkgWz1bKA1S4It525gtyoEU2xT5FGd4K1m X-Received: by 2002:aca:c4c5:: with SMTP id u188mr4438367oif.139.1585328771201; Fri, 27 Mar 2020 10:06:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585328771; cv=none; d=google.com; s=arc-20160816; b=MM2x3Qaug0UDpWb7ZkN/z+3xP+GAHQGXjkLARJDvQorJu35RWjU7dBUZD+TUB5YQLu rrT2VcIage0yf4TZaJ0MCjVFDcWcmbKYDxpy3yx8VBFgihkwujbhncT2vL4a6STBrxJP Ae4Y7WACHTE8LpJhac642FVgMy+pyI7zLFV/U+/PEqHlWcTcajSpoXo8O3zPS3BC3AaA iZhNiWctQoYh/Dj98upKoq0qVjCsIap+/O7+z5D07IZpOyhMRLWNDd+xolnlrTcwyoQx t4I+6eW4DvKUVvGp0VaFNtO4zNZJT2fepIVCSuZIvIQ0c5ngrzo8srdHC5Kw3OLvpunD 4kQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=2uSk5OmF7Is8u+ylzJyfXZPzvaBYULTp/WZBWkL3rbo=; b=tW2tO+deFTegfBae5ZuWm+aoMgIh1sI9sxXQMywCLWXDTdvV60CLWV4sR804ldNUEL ruI0qOYvwxtfFRTq/H6ZHZpE4eLyzj430m77hpWj3FQxA5XfLOIsaS2fnI5shv21D24p XdXlVkuGWLPq7Q91b3JQLP1qgZouk3BDkvrV+HujQHt7i870CzJpZwZrXNleejiI2hgs 8E+4NIdoOku5yf0vBe/4l1/xy+nDbBKjIUHTmuWQwox6/aU1MpPtguY4fR7buPUr7w9g 8U2KkZipAuG1kiBHcurJIA+dV3js6esjnKXyU4O65IGSxwVv4BYxB3JcatfacJcmpwTS f+ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=x4GRhdLT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t132si2559731oih.173.2020.03.27.10.05.57; Fri, 27 Mar 2020 10:06:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=x4GRhdLT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbgC0RFH (ORCPT + 99 others); Fri, 27 Mar 2020 13:05:07 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36902 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbgC0RFG (ORCPT ); Fri, 27 Mar 2020 13:05:06 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02RGrUN7167850; Fri, 27 Mar 2020 17:04:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=2uSk5OmF7Is8u+ylzJyfXZPzvaBYULTp/WZBWkL3rbo=; b=x4GRhdLT20y/KfX33gRdU9TWV63b9LlKIKi007etL+l23nhyRDc/1A0pQcAiSlecM+5h EnvTwNGd/j6GozwGvLETzWjZHxub7Hh6Gd4mQGum2lRMCP53bWsl0p0PE424sMLGdqtr vYw+uVckIktqjGt6wQUXKeRhseWQRo9UsfJIXYhGv07YiBVyUAwH9GDwllU196WTTysc vy3AV8YFvVTdnw/YBIDMzYUUkGJMRYP8jSD00T3X9jS929M0tGE9Kzp0Wp/dP6ikl+b1 RgC9/0to3zQlwrsk3/JxGTRqAuxeJri8mcsnUX++AbBAHGUHYuc5zbk+wIlyffCOJ7PR 2w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 301459c9e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Mar 2020 17:04:43 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02RGr57S113183; Fri, 27 Mar 2020 17:04:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 30073h7308-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Mar 2020 17:04:42 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02RH4c6j005514; Fri, 27 Mar 2020 17:04:39 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Mar 2020 10:04:38 -0700 To: Can Guo Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Subhash Jadavani , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Bart Van Assche , Venkat Gopalakrishnan , Tomas Winkler , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v6 1/2] scsi: ufs: Clean up ufshcd_scale_clks() and clock scaling error out path From: "Martin K. Petersen" Organization: Oracle Corporation References: <1585214742-5466-1-git-send-email-cang@codeaurora.org> <1585214742-5466-2-git-send-email-cang@codeaurora.org> Date: Fri, 27 Mar 2020 13:04:33 -0400 In-Reply-To: <1585214742-5466-2-git-send-email-cang@codeaurora.org> (Can Guo's message of "Thu, 26 Mar 2020 02:25:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9573 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003270146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9573 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 impostorscore=0 mlxscore=0 spamscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003270146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can, > This change introduces a func ufshcd_set_clk_freq() to explicitly set > clock frequency so that it can be used in reset_and_resotre path and > in ufshcd_scale_clks(). Meanwhile, this change cleans up the clock > scaling error out path. Applied to 5.7/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering