Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2697715ybb; Fri, 27 Mar 2020 10:23:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs9wnu+QncxVDI0xSWZkBRavmmgi9X96EP5/xcP1TW2cth4F8eeHvy643sPc0GkSAqHInn8 X-Received: by 2002:a4a:5747:: with SMTP id u68mr407379ooa.32.1585329788888; Fri, 27 Mar 2020 10:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585329788; cv=none; d=google.com; s=arc-20160816; b=Ze2sI+SI9V4ltH2DDS39FLAYSngW3N+ityHXleY8DwaNo28vJBOtbQhG30IfxmRBMV AkqnbaAlg+QMcW0TX0tt0o7dP+Ky+IEsFnRf9TqRe+LaeTXV0r7gKsTJIUHKeD34dwJa /Y8hC9daJp3LKBetBOpNDfFcqr4woscEdsBj2VHEQwWbLeVSTClU2RJzKm10968QFxnz t5aCJIWGuGyvFltuZ1Aj+KQmnxaiWbLRY/MSVGa3MA5W+SiNpao/KMQVbQevaPdn1gQw TWcWZmNxs5fzbMCZusYJg2CWvb9geGJyJz6uRobzJngwdytee8iQaRCNJ3B+AC7lT1iA 2hTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zu84Lk9ZsJESnGutiEIJFcRLiZfTveWNTjUKtgtkel4=; b=uP/UGYiueBnAobWHHDbG7WvJuSgGqemU/JxHF3volwALWLqpmpTiO07YJIzjlen3Yt 9hD8yzv1bKkUW7803KxqXMOUNcTPuymhNqLpdqMmxKZ4+2wIs691G7jsiHxRv3mZ8vBO GfudbQaKEtBFYAW0J5A+2Kmtg5sc6Q0Yf65IfgvdmoE/qttaBa4/6c6jyfXGMrcTrlKo UuiX+Xq1dVLMh9ezUoYj/bGgxgJ1X4hYqbOo2dHXz43lmZwSum758wsb9QWrvvEhr89D CT6h0v3CHM5cfltbqlEXSHLs+SSY6Qq8kXAtdzJZosZQykOy7KC1fsAiVC84EJoFTga+ r3iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t132si2576981oih.173.2020.03.27.10.22.54; Fri, 27 Mar 2020 10:23:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727674AbgC0RW1 (ORCPT + 99 others); Fri, 27 Mar 2020 13:22:27 -0400 Received: from correo.us.es ([193.147.175.20]:37206 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727509AbgC0RW1 (ORCPT ); Fri, 27 Mar 2020 13:22:27 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id CA5BD1228CB for ; Fri, 27 Mar 2020 18:22:25 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BB4DCFC5E7 for ; Fri, 27 Mar 2020 18:22:25 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id A6072FC5F1; Fri, 27 Mar 2020 18:22:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CBD24DA736; Fri, 27 Mar 2020 18:22:23 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 27 Mar 2020 18:22:23 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A2EFD42EE395; Fri, 27 Mar 2020 18:22:23 +0100 (CET) Date: Fri, 27 Mar 2020 18:22:23 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jules Irenge Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "open list:NETFILTER" , "open list:NETFILTER" Subject: Re: [PATCH 4/8] netfilter: Add missing annotation for ctnetlink_parse_nat_setup() Message-ID: <20200327172223.4bsns76lkjumwn3q@salvia> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> <20200311010908.42366-5-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311010908.42366-5-jbi.octave@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 01:09:04AM +0000, Jules Irenge wrote: > Sparse reports a warning at ctnetlink_parse_nat_setup() > > warning: context imbalance in ctnetlink_parse_nat_setup() > - unexpected unlock > > The root cause is the missing annotation at ctnetlink_parse_nat_setup() > Add the missing __must_hold(RCU) annotation Applied, thanks.