Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2697924ybb; Fri, 27 Mar 2020 10:23:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtJq0ES0Ooi+JV+K4j1m/ecA9dczvubqDRu2Q6Bqr1MF1Q74Y1OLJy582H2ikG03lGX0dDT X-Received: by 2002:a4a:92cd:: with SMTP id j13mr392733ooh.96.1585329804203; Fri, 27 Mar 2020 10:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585329804; cv=none; d=google.com; s=arc-20160816; b=HbxXY+vVziG5/RxBNgaSsLYXSYxczoHlKvBJatKt7UA3CnV/ApHMoF2K8DYtO3kRRB n9OlkH3yGZlbjr4yKqXDAhOjs1uJXvUopqWPoDkG46CXa4LSUI5TPIcfyeBZctQOgWSf islfoaqDIFNjQmTVv+m6XhJWet1WJtBN7+QGVIVyYW0RHIT3xCRdhvDLOqZkz7BlisDZ aPMUALnZWLKqrTEd+Y9dCFHRpp86q8QKiOU3z5+tkNbZg/Rc2S29sy+H7ViOOuj/S71d hlD3ECnz+5NO7lfJ57r7Z2ZSyeqeiL20iL/fS6iE5cHhSstnszCo0MBNiT+n1H38zbWm xcIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=opUCfpB/vJnICTRXjc2LqDTUb/YrfHR3GBA+oQd3QaY=; b=A89YQOJ0LViuK/VQbC6eh2znHqb/0fCn75a6LhoPwntxyqo2q+SeBGmLvGgIR8Zq3o cy7iTB/VFI7yXfUtdQ7RfiI+9D4oQElXVdK8ZukgrmOcr/pXPo4iZgphetchuInLStIm zN2S0PEGC5gspOSuhJVUWlMXeMicts4+sKuNjzGFHAQapnnQ/v0J6jo6e0mrUaYOHUT9 DC9DqKytDQAWRMF0QXhJDY+7Fr+isw4kRwORsmjwHGmkmy5lLapgDPIaf7i2XqVnF7x2 MN+5V2Ye84V0lUPoxGIFTB4w5rbLugn8mDYqr9m6DoWXC92TV8cbFMeIJCpMXQOTv3A0 l/Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v24si2324269oot.29.2020.03.27.10.23.11; Fri, 27 Mar 2020 10:23:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727736AbgC0RWi (ORCPT + 99 others); Fri, 27 Mar 2020 13:22:38 -0400 Received: from correo.us.es ([193.147.175.20]:37332 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727714AbgC0RWi (ORCPT ); Fri, 27 Mar 2020 13:22:38 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4C0D361EA3 for ; Fri, 27 Mar 2020 18:22:36 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3E4ECDA39F for ; Fri, 27 Mar 2020 18:22:36 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 33F6CDA736; Fri, 27 Mar 2020 18:22:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 553DCDA3A3; Fri, 27 Mar 2020 18:22:34 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 27 Mar 2020 18:22:34 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 2BADE42EE395; Fri, 27 Mar 2020 18:22:34 +0100 (CET) Date: Fri, 27 Mar 2020 18:22:33 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jules Irenge Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "open list:NETFILTER" , "open list:NETFILTER" Subject: Re: [PATCH 5/8] netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock() Message-ID: <20200327172233.4koyonq3iqp6pmy4@salvia> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> <20200311010908.42366-6-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311010908.42366-6-jbi.octave@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 01:09:05AM +0000, Jules Irenge wrote: > Sparse reports warnings at nf_conntrack_all_lock() > and nf_conntrack_all_unlock() > > warning: context imbalance in nf_conntrack_all_lock() > - wrong count at exit > warning: context imbalance in nf_conntrack_all_unlock() > - unexpected unlock > > Add the missing __acquires(&nf_conntrack_locks_all_lock) > Add missing __releases(&nf_conntrack_locks_all_lock) Also applied, thanks.