Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Zi Yan <ziy@nvidia.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH 3/7] khugepaged: Drain LRU add pagevec to get rid of extra
 pins
Date:   Fri, 27 Mar 2020 13:34:20 -0400
Message-ID: <D4EBA00D-BD65-4B7A-8C39-75DE43BD8CB8@nvidia.com>
In-Reply-To: <20200327170601.18563-4-kirill.shutemov@linux.intel.com>
References: <20200327170601.18563-1-kirill.shutemov@linux.intel.com>
 <20200327170601.18563-4-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_E59B323E-9281-4760-BAF4-CA84DE210BFD_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=_MailMate_E59B323E-9281-4760-BAF4-CA84DE210BFD_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 27 Mar 2020, at 13:05, Kirill A. Shutemov wrote:

> __collapse_huge_page_isolate() may fail due to extra pin in the LRU add=

> pagevec. It's petty common for swapin case: we swap in pages just to
> fail due to the extra pin.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  mm/khugepaged.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 14d7afc90786..39e0994abeb8 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -585,11 +585,19 @@ static int __collapse_huge_page_isolate(struct vm=
_area_struct *vma,
>  		 * The page must only be referenced by the scanned process
>  		 * and page swap cache.
>  		 */
> +		if (page_count(page) !=3D 1 + PageSwapCache(page)) {
> +			/*
> +			 * Drain pagevec and retry just in case we can get rid
> +			 * of the extra pin, like in swapin case.
> +			 */
> +			lru_add_drain();
> +		}
>  		if (page_count(page) !=3D 1 + PageSwapCache(page)) {
>  			unlock_page(page);
>  			result =3D SCAN_PAGE_COUNT;
>  			goto out;
>  		}
> +
>  		if (pte_write(pteval)) {
>  			writable =3D true;
>  		} else {
> -- =

> 2.26.0

Looks good to me. Is the added empty line intentional?

Reviewed-by: Zi Yan <ziy@nvidia.com>

=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_E59B323E-9281-4760-BAF4-CA84DE210BFD_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl5+ORwPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK9MMP/1nsFKGD1peS8idFNCM1mo3r5sZA9Kf8jcYH
MIQYUcwgprJn9PVaL9DI605sISqVsS8D6LrlVKfv14MerGlOYJ4360QvjUNJrgeb
GhNjVjzpP0AB0BcDtAemFW/ECT3x2/rP4+sVfr2iceJmbj5cybqb0GwAbvOcC3Dg
E2a73gBMuXV8nEyXsl5h/Za2PU31aX5z2A42/67dMJVFTXpPppQNzvXsXHjxEoBL
AzX9Y8B3SE+OY7mnchWcDWRmtGL4jDOpChdIhZE6lfebmDFzk9+59nEo8+QPQwpP
pjFKq04kkwgALNp4aoAJp6DFpGDhJoN+xHYAxUQWxmVCCEJqg4QSHOL/rpaIDZ8m
0z4KdWe36F+ligELPjh1C5lKcprk6y2HJCJ9ET3OeSEfd+j6Ngdblzv4CFI16fU8
A36VAiEHu3rEW0Z2MpGy4c5LGndKBiByo1pblaZha0gwNQ0QM6FYc4nHHj9Kvv/6
gAs1JEasDtEEKqw+gUYtp/yD9c9xgY3FJLXMszXhw9l0KV7X2TtKbasYF3VrANDM
R1BN7sVngTJZghkU6uhFZQpbFzBEpQ+nMp9hZfQmpP4pJR5NNJBYcg3aWrFPsRu8
xYy6W84AystU6VYzcpI5Q0r36acVOOa6Mmlm/H/92i5PB8LDBYs033Nkr4cLNV2B
I2iJHWwr
=HkBS
-----END PGP SIGNATURE-----

--=_MailMate_E59B323E-9281-4760-BAF4-CA84DE210BFD_=--