Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2893668ybb; Fri, 27 Mar 2020 14:09:12 -0700 (PDT) X-Google-Smtp-Source: ADFU+vudlpUAy4pltGU02lOTD0UhpMewNYY5X411Dfj44rvCFeLMaT6Bq6tpPXmqaJjvwaSBVj/l X-Received: by 2002:a05:6830:1c65:: with SMTP id s5mr537789otg.25.1585343352075; Fri, 27 Mar 2020 14:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585343352; cv=none; d=google.com; s=arc-20160816; b=KzMWLprfElxA4HdfbQBmyEvGf1DPUA3QDjGxPHhmGbiuQhm6DZd0UN85P+LOXOU6KX 14yjSXr0tACb5aaZxEkRgzZu/Uo8W6/DLEjNY83nE9PwhIn8iuHLvfkcRWM8hvxqVOhH gOIQ4xZXWDq4CjymBNarLqQRVRvOQ9O9ejU3khipawVBaXJrPhhhlJexIqo0fqWsw3FL CDKzgc0EzXqtMZc5+lRlVtDlnfzdKsM7pl7n7kqrcjwzCAHejh2vDsuTwlwEAg4t7GMF jV1ya2BF5taxPOSx2lg8BAQHA4MXOOtViQeFXibOMyCpAH+1YgDUeGsgO3MLK+8+1Dce TBNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vy4A4qxxBdA1VleutrEnlGSM+k4IB/RyFCwjbH/DwRs=; b=SkcuDj9xasRLhc3SjFQRJaiR9Ty40u5dXHZ/RvdUaVdMqe7K/dGDcpDzaoYnXkhvAv 7ySX0kuCwvI0IpTDiPcEMcCUHsrAZ+vSy4NkijhZCvfZlTbt+pHw+I1Ba0Hc+cjQfzf+ B/R0LOL7LEWwdT33mWhtmKWkqBF6puHeiwqv+B5gCb1xgPF4nHEYt30WERHjm0eNBhCi PV1CV7Ml3fYuJLXP4JXCkvCqNKm9/0wgglFL5i8nIUpsLHM2qNKoqlCNffYoFntcPT+N v1AgeQ6YoVY5zd3gIXlVLDnGQnucH5W0UNCyICdJEoglucjOKRXcr2rSC2cE1KC19i5s cbqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=insSbL1Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i187si2931651oif.89.2020.03.27.14.08.53; Fri, 27 Mar 2020 14:09:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=insSbL1Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgC0VIE (ORCPT + 99 others); Fri, 27 Mar 2020 17:08:04 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:44428 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727352AbgC0VID (ORCPT ); Fri, 27 Mar 2020 17:08:03 -0400 Received: by mail-lf1-f68.google.com with SMTP id j188so9028136lfj.11 for ; Fri, 27 Mar 2020 14:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vy4A4qxxBdA1VleutrEnlGSM+k4IB/RyFCwjbH/DwRs=; b=insSbL1QKr3lV5AjtxrrpT3lHkcvsXqses2tRsZBuLG1gwklF0Y+N9EVvzO07/hLsU wu7zN34y5FLWLN1QLMBlpmL2STUMMAzQAF6tn6tg0u1uOjM74xN7q2yogJX5qzuPbGEH Lqt+dYUamNPhBQZSOKc47DW762uhfVqspYXWTddaXEu2ykfgBgpWzthwxPwSBov1/InY s4nv0AARFXvOo5+nzswznHeguw6+EedK9hShcRc06x2wu97IvqF96Ap4/hfn3+sXlpgI yN1bTDXjyZSxMYQE7GzhErFJYfgV3AXbBd4P473sH8JuScGH6LSMOQ5aOfznVunftSWt N67A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vy4A4qxxBdA1VleutrEnlGSM+k4IB/RyFCwjbH/DwRs=; b=b92dGxWqE9Vu2b0vKSN9wiaUElOQR7U4jymubwdFxf1qQuZom3NYYVA+x0yqYIDHGN IASq4X7iTawi5lQDHaskirQsv52OD5k/kxlytHS5LQO3YWjLJnWkKVqU+MA1SmPKiSCH W/wfpAJO6q4EL4MOn9cJgASQ40DoWvemMepUaPiNbhi6fv9L+KsUzzei2oPbSGVI+ZCe YJzt+xxzh7a0iEsPuchZ2CDKzgo6kILabXXFaDWlhi577/fbNu/wLGQBJ64aqRPdeQuK Ln/k/fPWfj3vBzWVShcmkd28Fr2T3V1BT/qiX+mGlwNOIo/zw+Tm6SHKrPWnIIIm+2d7 +L6w== X-Gm-Message-State: AGi0PubMIc6PdU/fopxT24AZuDSOR5EgmvIIDrPNFCPLWND7cKCni1hd Qszq+sggWZssBlRmd7r4nUlzEvDyng7kpWZk284Ebw== X-Received: by 2002:ac2:5b49:: with SMTP id i9mr749117lfp.21.1585343282366; Fri, 27 Mar 2020 14:08:02 -0700 (PDT) MIME-Version: 1.0 References: <8a6f91b49c17beb218e46b23084f59a7c7260f86.1585124562.git.baolin.wang7@gmail.com> In-Reply-To: <8a6f91b49c17beb218e46b23084f59a7c7260f86.1585124562.git.baolin.wang7@gmail.com> From: Linus Walleij Date: Fri, 27 Mar 2020 22:07:51 +0100 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: sprd: Use the correct pin output configuration To: Baolin Wang Cc: linhua.xu@unisoc.com, Orson Zhai , Lyra Zhang , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 9:25 AM Baolin Wang wrote: > From: Linhua Xu > > The Spreadtrum pin controller did not supply registers to set high level > or low level for output mode, instead we should let the pin controller > current configuration drive values on the line. So we should use the > PIN_CONFIG_OUTPUT_ENABLE configuration to enable or disable the output > mode. > > [Baolin Wang changes the commit message] > Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver") > Signed-off-by: Linhua Xu > Signed-off-by: Baolin Wang Patch applied. Yours, Linus Walleij