Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Michael Grzeschik <m.grzeschik@pengutronix.de>, lars@metafoo.de,
        alexandru.Ardelean@analog.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, bigeasy@linutronix.de,
        m.olbrich@pengutronix.de, kernel@pengutronix.de
Subject: Re: [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints
In-Reply-To: <20200327084302.606-1-m.grzeschik@pengutronix.de>
References: <dc52d6a0-12ed-a34c-01c4-0fc5ccbf7b1d@metafoo.de> <20200327084302.606-1-m.grzeschik@pengutronix.de>
Date:   Sat, 28 Mar 2020 10:27:49 +0200
Message-ID: <875zeokhoa.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Michael Grzeschik <m.grzeschik@pengutronix.de> writes:
> dwc3_gadget_ep_disable gets called before the last request gets
> dequeued.
>
> In __dwc3_gadget_ep_disable all started, pending and cancelled
> lists for this endpoint will call dwc3_gadget_giveback in
> dwc3_remove_requests.
>
> After that no list containing the afterwards dequed request,
> therefor it is not necessary to run the dequeue routine.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> @Lars-Peter Clausen:
>
> This patch addresses the case that not queued requests get dequeued.
> The only case that this happens seems on disabling the gadget.
>
>  drivers/usb/dwc3/gadget.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 9a6f741d1db0dc..5d4fa8d6c93e49 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1609,6 +1609,9 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
>=20=20
>  	trace_dwc3_ep_dequeue(req);
>=20=20
> +	if (!(dep->flags & DWC3_EP_ENABLED))
> +		return 0;

which driver is trying to call dequeue after the endpoint is disabled?
Got some tracepoints of the problem happening?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl5/CoYACgkQzL64meEa
mQY47A/9F0MvaAz3S1tMcdQ9GJzZkykuDn0kwTsSU8Q03UGPUlJlD99/JvfdpFtU
uqdQMdgQf6NTxQvsE5GPyjkP0nVp8EwUEV+YdeM4hHLumSUEwHtYipQpSVkyUkVK
fpj6wP3Nt0z9OgLtJYAS4PR6nbd14MF7nAejWHO0hNkEjX01i7+KTtOyebyIVTQn
+FkA21J5g5rRyuacjWTc+X+YeCxxCcEFOP8SmdBPOAjeFCH63A5HQKb42BZgXb6o
KkKKClpWX1oq52jB6vukgN9dMqkpC/0OlfP+eXI/sfkNN8115Z2/oZvAt3fiww2F
vYcWSN9PF+Ce5rL/8Y130LHuSABEJ/bg7QD1cM82HRjSkkjzuhh3cbqJAm8dQEPM
19UgTemKsFY813EhyO0xZehh7AZ7OaqQihv/1ZjYxF6Y9+PuZkrw82I/TX52BeBx
MUaBzTkBxpkyUJUoiQpi5n2lcnsntqjaS0tRgQWgd9+mvkipVn/YfT0tqT7fyRvC
Nh6z5miQxKOUov8XRKWxseEk3PhuUdLsjgBBs4xmMy8/C74TGERTh0g/mV2iRq8i
/7r2sRoG8EvMQ0M4ABfH8Bsgmv+eSmpLVLQM8JcjgaoZeKp+V2O1MM1oJLabot7o
3y//MzQhRQyNhKqUac4syozGE/Bc+0Ox3SxErjR/N3N/W+073GY=
=0Q4s
-----END PGP SIGNATURE-----
--=-=-=--