Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Rohit Sarkar <rohitsarkar5398@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC:     "jic23@kernel.org" <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: RE: [PATCH] iio: temperature: ltc2983: remove redundant comparison to
 bool
Thread-Topic: [PATCH] iio: temperature: ltc2983: remove redundant comparison
 to bool
Thread-Index: AQHWBM2PtVEh+oC/9Uy2VzpjHg8Q66hdwQlg
Date:   Sat, 28 Mar 2020 09:43:58 +0000
Message-ID: <BN6PR03MB3347A202426BE1F409B3A68599CD0@BN6PR03MB3347.namprd03.prod.outlook.com>
References: <5e7ef454.1c69fb81.56770.82c7@mx.google.com>
In-Reply-To: <5e7ef454.1c69fb81.56770.82c7@mx.google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: analog.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9b9798-8ecb-4c0b-57b3-08d7d2fc8a45
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2020 09:43:58.8317
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mWMougPtKdIHEdgSxIG+zMxH4EJDn7J20un4T6kNRI/AkLFWmhN2DBgWRHJMlZ6LfPPP9r4OkUb4aqh7RNRRNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3250
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645
 definitions=2020-03-28_03:2020-03-27,2020-03-28 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0
 mlxscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 adultscore=0
 spamscore=0 clxscore=1011 bulkscore=0 impostorscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000
 definitions=main-2003280091
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rohit Sarkar <rohitsarkar5398@gmail.com>
> Sent: Samstag, 28. M=E4rz 2020 07:53
> To: linux-iio@vger.kernel.org
> Cc: Sa, Nuno <Nuno.Sa@analog.com>; rohitsarkar5398@gmail.com;
> jic23@kernel.org; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen
> <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org; Bogdan, Dragos
> <Dragos.Bogdan@analog.com>
> Subject: [PATCH] iio: temperature: ltc2983: remove redundant comparison t=
o
> bool
>=20
>=20
> Remove redundant comparison to a boolean variable.
>=20
> Fixes coccinelle warning:
> drivers/iio/temperature//ltc2983.c:393:20-32: WARNING: Comparison to
> bool
> drivers/iio/temperature//ltc2983.c:394:20-32: WARNING: Comparison to
> bool
>=20
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
>  drivers/iio/temperature/ltc2983.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/temperature/ltc2983.c
> b/drivers/iio/temperature/ltc2983.c
> index d39c0d6b77f1..8976e8d59826 100644
> --- a/drivers/iio/temperature/ltc2983.c
> +++ b/drivers/iio/temperature/ltc2983.c
> @@ -390,8 +390,8 @@ static struct ltc2983_custom_sensor
> *__ltc2983_custom_sensor_new(
>  	 * For custom steinhart, the full u32 is taken. For all the others
>  	 * the MSB is discarded.
>  	 */
> -	const u8 n_size =3D (is_steinhart =3D=3D true) ? 4 : 3;
> -	const u8 e_size =3D (is_steinhart =3D=3D true) ? sizeof(u32) : sizeof(u=
64);
> +	const u8 n_size =3D is_steinhart ? 4 : 3;
> +	const u8 e_size =3D is_steinhart ? sizeof(u32) : sizeof(u64);
>=20
>  	n_entries =3D of_property_count_elems_of_size(np, propname, e_size);
>  	/* n_entries must be an even number */
> --

Acked-by: Nuno S=E1 <nuno.sa@analog.com>

Thanks,
Nuno S=E1