Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: hBg2sFQHt1JubBncDNw55azrPrybNHMWrBnlIG0FTxnX4fe5ih5vfaYyRuY/lPpn/EM8IF1/r+
 Q0eYptqAbkQw==
IronPort-SDR: Ty0aWSLn7xpvRb45MfRsnCppMnFf+6knk25yfjfkwR5OCsTTF24GCKsio6GBkmz3/D3rLsgV3l
 Dk6wYFjpylZg==
Date:   Sat, 28 Mar 2020 18:39:50 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] PM / sleep: Add pm_debug_messages boot command control
Message-ID: <20200328103949.GA16999@chenyu-office.sh.intel.com>
References: <20200327111141.14324-1-yu.c.chen@intel.com>
 <a9843786-e7da-2c3c-30e2-c4887e9af4c6@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a9843786-e7da-2c3c-30e2-c4887e9af4c6@infradead.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Randy,
On Fri, Mar 27, 2020 at 08:39:44AM -0700, Randy Dunlap wrote:
> On 3/27/20 4:11 AM, Chen Yu wrote:
> > Debug messages from the system suspend/hibernation infrastructure
> > is disabled by default, and can only be enabled after the system
> > has boot up via /sys/power/pm_debug_messages. This makes the hibernation
> > resume hard to track as it involves system boot up across hibernation.
> > There's no chance for software_resume() to track the resume process,
> > eg.
> > 
> > Turning on the pm_debug_messages during boot up by appending
> > 'pm_debug_message'.
> 
> Please add that command line option to
> Documentation/admin-guide/kernel-parameters.txt.
> Thanks.
> 
Thanks for pointing it out, I'll add it in the v2 patch.
Thanks,
Chenyu
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@infradead.org>