Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp489701ybb; Sat, 28 Mar 2020 03:54:03 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsDS1EAuvr1+matVUMYt9ErNr2W62EuJ1wxj7ne3byF9gGKfOgC8JDWjV0usK+/dSKyX86X X-Received: by 2002:a4a:8041:: with SMTP id y1mr2875498oof.65.1585392843361; Sat, 28 Mar 2020 03:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585392843; cv=none; d=google.com; s=arc-20160816; b=HHAEEhozXW4YiWYh+xGLB7j6Kr8J0LrOygqbjK2/IseHgRM4pj/36nV3bcWXHS0kXk DfOHqdhjfUCT/k01uBEbk7F1XqSebzS0XHIN2VrMZU412afBMQ4ML5ehMDCI7qmd4KNE ZqYm/+lh4/k5gBdWTA3aW525ANO0nhvI6u+mKMB5S+sKIaPwal91sRGdU4jQrelv2kPj fByY4Ep/GqTvgB/ZBFuQeJr0optWH8HBCBvh89oR+FDdgjNc/yH4yJtAPac8rE2KngqK XllHbbE5ujc1HlxFKxJvEytWJvvUCppfc2XItpY9tBNgEUMvn0+RY3YcmHChVMe+qhot kfwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YcKn/H8EDvahzikQuDQ0C/2jv4PkNkkgCQKKj34zNzU=; b=VjvVghxjCEcFzOMuntf2HtdqIOjf9mMaLgV+1gqtvd49vZ7QXDlAR+jZujqvaTTWAW GwniibQPxtyLO0HEvG2BSbzojZnURw05+mjDrla8DNZjSVs1qr3f6u47zUqKjbd6smPg q3U0omAX2etjiuBkl7enKiI8ZWhdgpG2ClUEpoDNLBFGE37FfOsZrQrHiUoMVNjMghGx 0cmk0tZLyZwitRsMcYClchLhWlxvSgBeap96gTm1nGTsCWRCrPvC7lGDHlyCdpTc2XaB yZkxatPtzgvQWV/uLAaHOy1Xc3tFzob1mEXw19lV7fgikiNsXWz2FHvOsB/+500PzO3N ydVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Aq4+5gmj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t83si3609624oig.239.2020.03.28.03.53.49; Sat, 28 Mar 2020 03:54:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Aq4+5gmj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbgC1KwY (ORCPT + 99 others); Sat, 28 Mar 2020 06:52:24 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41513 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgC1KwY (ORCPT ); Sat, 28 Mar 2020 06:52:24 -0400 Received: by mail-pl1-f195.google.com with SMTP id d24so678489pll.8; Sat, 28 Mar 2020 03:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YcKn/H8EDvahzikQuDQ0C/2jv4PkNkkgCQKKj34zNzU=; b=Aq4+5gmji624zQXh/p3KCAR+m5x43hob634OL/vHwySR8euy8H9Z1vnBgp970IK8eD x24zEis9Y7h6I10OLNJ1oLzuoWRlnMBrL59ojvdpXzWNVKnpAfjCE/quPUckA0C84GB6 ojq87jZ+RoyuIgX3Ch2qpzoMhIFzyqBzoT0/xAxdTnbi6uRbG8HtDmi46tAMTSdtL/NB yUpvK1ndDbPWHjwv5heS52sIEDeI0RsheV2+o2WWh8GzMwD35mlSn3qnsbpVBnUb0/NK OhiPGGPWMGjxHfLiw6D7fqYAZ+E/MZC0FemWrtD2K+5H4+jrFAqdWjApUEyvROiaysas hNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YcKn/H8EDvahzikQuDQ0C/2jv4PkNkkgCQKKj34zNzU=; b=OaGzN7ONZYLBdjZtGmpZaKhSP0+wC5Rqzao6bPf5jK0gs2zGqvJBq+gX7hMolUaBWS LRZu4OFJtGDs3TEA2/H4iYdtv4Py1pLn/d9kyytLrFaQnWaoFE4MGqIqKN8fYiOUnhPO y5hjjsMg9Q9h2lZINaxn3mMFmnk9j+FHR2MnBthULMnkIm6iu4piLXPjZWUgjdF/z3cB 8ARFh/5u+xWjbqEg1vNJYLqLm7wTEBEqu1c+H9Ui5vGH/cUtuHW9DD9OzVX0E4C/Afpk qZKuXDC4eRD99dIidWrBZIGAqgWfWruOXwHCgnO6UNMlUwfOXCgkxKu53kJ9yPKH2K0o ZKaw== X-Gm-Message-State: ANhLgQ2+Gkiz3BjWhYWrspC54XMPW2jt2YAqnRQ9i3X6VdkbokzJAuZg JYUT8tlcQ8qPVm4GpmWmBJ3EZp/bdG0P9OFBEIA= X-Received: by 2002:a17:90a:8403:: with SMTP id j3mr4422773pjn.8.1585392742658; Sat, 28 Mar 2020 03:52:22 -0700 (PDT) MIME-Version: 1.0 References: <20200328001154.17313-1-sravanhome@gmail.com> <20200328001154.17313-4-sravanhome@gmail.com> In-Reply-To: <20200328001154.17313-4-sravanhome@gmail.com> From: Andy Shevchenko Date: Sat, 28 Mar 2020 12:52:11 +0200 Message-ID: Subject: Re: [PATCH v5 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar wrote: > > Add support for 8-bit resolution ADC readings for input power > supply and battery charging measurement. Provides voltage, current > readings to mp2629 power supply driver. ... > + ret = regmap_read(info->regmap, chan->address, &rval); > + if (ret < 0) ' < 0' is not needed for regmap call. .. > + case MP2629_INPUT_CURRENT: > + *val = 133; > + *val2 = 10; > + return IIO_VAL_FRACTIONAL; > + > + default: > + return -EINVAL; > + } > + > + default: > + return -EINVAL; > + } > + > + return 0; Do you really need this? Looks to me as dead code. ... > + indio_dev->name = dev_name(dev); Shouldn't be this a part number? I heard something, so, I might be mistaken, but I hope maintainers will help here. -- With Best Regards, Andy Shevchenko