Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200328001154.17313-1-sravanhome@gmail.com> <20200328001154.17313-3-sravanhome@gmail.com>
 <CAHp75Vdc4MxMnmd_h6eFfZAji=4fir7x7bq2MX1q50nAQ1eJ=Q@mail.gmail.com> <23c39834-c2d9-5634-b9d7-8f9e16194752@gmail.com>
In-Reply-To: <23c39834-c2d9-5634-b9d7-8f9e16194752@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 28 Mar 2020 13:06:17 +0200
Message-ID: <CAHp75VcAh07Kb+G5HoZfgWwKTCfRHLcX7nD=g8r3+z5sm4u-dQ@mail.gmail.com>
Subject: Re: [PATCH v5 2/5] mfd: mp2629: Add support for mps battery charger
To:     saravanan sekar <sravanhome@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        Sebastian Reichel <sre@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 28, 2020 at 12:51 PM saravanan sekar <sravanhome@gmail.com> wrote:
>
> Hi Andy,
>
> On 28/03/20 11:45 am, Andy Shevchenko wrote:
> > On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
> >> mp2629 is a highly-integrated switching-mode battery charge management
> >> device for single-cell Li-ion or Li-polymer battery.
> >>
> >> Add MFD core enables chip access for ADC driver for battery readings,
> >> and a power supply battery-charger driver
> > ...
> >
> >> +#ifndef __MP2629_H__
> >> +#define __MP2629_H__
> >> +#include <linux/device.h>
> >> +#include <linux/regmap.h>
> >> +#include <linux/types.h>
> > None of these header is in use here.
> >
> > struct device;
> > struct regmap;
> >
> > would be enough.
>
> Yesterday I conveyed to you that Lee is not recommended to use forward
> declaration and asked me
>
> to use includes, then you agreed with the same. Again same comments !!
> sorry I am lost.

Ah, okay. I missed that.
But types.h is still not needed, all data types are provided either by
C or by rest two headers.

> >> +struct mp2629_info {
> >> +       struct device *dev;
> >> +       struct regmap *regmap;
> >> +};
> >> +
> >> +#endif

-- 
With Best Regards,
Andy Shevchenko