Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp516249ybb; Sat, 28 Mar 2020 04:29:49 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv1kp3VJeOFn57n/WnZRpvPRS4DKZJytgeXQahSpcy64r0wXYt/ZiAMXDi27vVtqDDJiH0Z X-Received: by 2002:a05:6830:20cf:: with SMTP id z15mr2121558otq.47.1585394989595; Sat, 28 Mar 2020 04:29:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585394989; cv=none; d=google.com; s=arc-20160816; b=m6Io1zJ5j99NejrbBmeWLrkEfZCeHNd4Oa2hNu4UEWxjIMBOpg1NkZRuLEBgUC6tZM 87Y1AzSXuAKOT6+HfrTaVDiICdLMfkL73i9CzN/cTRUPJcQ4yGrC2E9X5H/plvBFdLog cAaxEd5Bx0NL6zwgFLh48xHiqmIcNKSXizLKnizVXVYiKuelZM7N34P5GlluyapzMG17 9HRTf3EsHVOCTVEhLv7sgXodzOn6smgG6ELLLcrXp8H+T+JMs8tFi9mI7soXq+5Gu8jC xPNS+uBnqTJkSvYRpCUI37XZg2TOu131Mmoiuu8Hcpdap4LysnGrEMMuAgAOdPQGFvRj 6Q5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=h0FT9weftMpXtlOT/rHGXhy5c5bXvpstkX32bE2z6dI=; b=Z+H0EVwDeiPNN0MIqiMBTE+/2uMDA8p+f+zQhEJyeafk/XGfFvcfGS+iUPGmooXiLp FdyR4kCbS4fx0eTdcwR/WehYfRkI1A0uRxaCEm3E1mZ/p4CAFUO7+SVqOcLBNxO7hCwV 1/Nm9u1bKMGTIvvVUbPEwI4F+sz/dOEXrB2OAP5js78XXhgcTmL4/HkpVH4AxD+NG0cC F0i2yy21WzkL8XmSSgHm2UiWVQsRxDmd+KZu4CNbNZoXMEder+0hxpmLBXaDodxqApqN t7AhbwDheB4NjcxasBIjl+myZUBMD0gplnvE42Bx09wgDUnXaSttcVLA5VajJd+h0GZS /EjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c203si3475587oib.273.2020.03.28.04.29.37; Sat, 28 Mar 2020 04:29:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbgC1L2n (ORCPT + 99 others); Sat, 28 Mar 2020 07:28:43 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:55674 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbgC1L2n (ORCPT ); Sat, 28 Mar 2020 07:28:43 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jI9df-0004CF-9R; Sat, 28 Mar 2020 12:28:31 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id E51DE1040C1; Sat, 28 Mar 2020 12:28:30 +0100 (CET) From: Thomas Gleixner To: Jules Irenge , julia.lawall@lip6.fr Cc: boqun.feng@gmail.com, Jules Irenge , Peter Zijlstra , Ingo Molnar , Will Deacon , "open list\:LOCKING PRIMITIVES" Subject: Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool In-Reply-To: <20200327212358.5752-2-jbi.octave@gmail.com> References: <20200327212358.5752-1-jbi.octave@gmail.com> <20200327212358.5752-2-jbi.octave@gmail.com> Date: Sat, 28 Mar 2020 12:28:30 +0100 Message-ID: <87y2rkwwf5.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jules Irenge writes: > From: Jules Irenge > > Coccinelle reports a warning inside rt_mutex_slowunlock() > > WARNING: Comparison to bool > > To fix this, the comparison to bool is removed > This not only fixes the issue but also removes the unnecessary comparison. > > Remove comparison to bool So you explain 3 times in different ways that the comparison to bool is removed. What's the point? Thanks, tglx