Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jules Irenge <jbi.octave@gmail.com>
Date:   Sat, 28 Mar 2020 12:00:32 +0000 (GMT)
To:     Steven Rostedt <rostedt@goodmis.org>
cc:     Jules Irenge <jbi.octave@gmail.com>, julia.lawall@lip6.fr,
        boqun.feng@gmail.com, Ingo Molnar <mingo@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/10] trace: Replace printk and WARN_ON with WARN
In-Reply-To: <20200327185138.5e98e17b@gandalf.local.home>
Message-ID: <alpine.LNX.2.21.1.2003281159330.20453@ninjahost.lan>
References: <0/10> <20200327212358.5752-1-jbi.octave@gmail.com> <20200327212358.5752-11-jbi.octave@gmail.com> <20200327185138.5e98e17b@gandalf.local.home>
User-Agent: Alpine 2.21.1 (LNX 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Fri, 27 Mar 2020, Steven Rostedt wrote:

> On Fri, 27 Mar 2020 21:23:57 +0000
> Jules Irenge <jbi.octave@gmail.com> wrote:
> 
> > Coccinelle suggests replacing printk and WARN_ON with WARN
> > 
> > SUGGESTION: printk + WARN_ON can be just WARN.
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  kernel/trace/trace.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 6b11e4e2150c..1fe31272ea73 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1799,9 +1799,7 @@ static int run_tracer_selftest(struct tracer *type)
> >  	/* the test is responsible for resetting too */
> >  	tr->current_trace = saved_tracer;
> >  	if (ret) {
> > -		printk(KERN_CONT "FAILED!\n");
> > -		/* Add the warning after printing 'FAILED' */
> 
> NACK! Did you not read the above comment. The FAILED goes with another
> print and should NOT be part of the WARN_ON.
> 
> -- Steve
> 
> > -		WARN_ON(1);
> > +		WARN(1, "FAILED!\n");
> >  		return -1;
> >  	}
> >  	/* Only reset on passing, to avoid touching corrupted buffers */
> 
> 
Thanks for the feedback, I will be more careful next time.
Kind regards,
Jules