Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jules Irenge <jbi.octave@gmail.com>
Date:   Sat, 28 Mar 2020 12:02:14 +0000 (GMT)
To:     Thomas Gleixner <tglx@linutronix.de>
cc:     Jules Irenge <jbi.octave@gmail.com>, julia.lawall@lip6.fr,
        boqun.feng@gmail.com, Jules Irenge <jbi.octave@example.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        "open list:LOCKING PRIMITIVES" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool
In-Reply-To: <87y2rkwwf5.fsf@nanos.tec.linutronix.de>
Message-ID: <alpine.LNX.2.21.1.2003281201270.20453@ninjahost.lan>
References: <20200327212358.5752-1-jbi.octave@gmail.com> <20200327212358.5752-2-jbi.octave@gmail.com> <87y2rkwwf5.fsf@nanos.tec.linutronix.de>
User-Agent: Alpine 2.21.1 (LNX 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Sat, 28 Mar 2020, Thomas Gleixner wrote:

> Jules Irenge <jbi.octave@gmail.com> writes:
> 
> > From: Jules Irenge <jbi.octave@example.com>
> >
> > Coccinelle reports a warning inside rt_mutex_slowunlock()
> >
> > WARNING: Comparison to bool
> >
> > To fix this, the comparison to bool is removed
> > This not only fixes the issue but also removes the unnecessary comparison.
> >
> > Remove comparison to bool
> 
> So you explain 3 times in different ways that the comparison to bool is
> removed. What's the point?
> 
> Thanks,
> 
>         tglx
> 
> 
> 
Thanks for the feedback I take good note. I will improve next time.