Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     =?UTF-8?Q?'Pawe=C5=82_Chmiel'?= <pawel.mikolaj.chmiel@gmail.com>,
        <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>
Cc:     <krzk@kernel.org>, <avri.altman@wdc.com>,
        <martin.petersen@oracle.com>, <kwmad.kim@samsung.com>,
        <stanley.chu@mediatek.com>, <cang@codeaurora.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <ac67cfc3736cf50c716b823a59af878d59b7198f.camel@gmail.com>
Subject: RE: [PATCH v4 5/5] arm64: dts: Add node for ufs exynos7
Date:   Sat, 28 Mar 2020 21:05:23 +0530
Message-ID: <000801d60516$823fd890$86bf89b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKI+vJzlUBp7WIi19k8pRZBKIHK2gKUSzVAA7h3SyUCe2DDm6ax9Wig
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200327170638.17670-1-alim.akhtar@samsung.com>
        <CGME20200327171423epcas5p485d227f19e45999ad9b42b21d2864e4a@epcas5p4.samsung.com>
        <20200327170638.17670-6-alim.akhtar@samsung.com>
        <ac67cfc3736cf50c716b823a59af878d59b7198f.camel@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Pawel

> -----Original Message-----
> From: Pawe=C5=82=20Chmiel=20<pawel.mikolaj.chmiel=40gmail.com>=0D=0A>=20S=
ent:=2028=20March=202020=2019:00=0D=0A>=20To:=20Alim=20Akhtar=20<alim.akhta=
r=40samsung.com>;=20robh+dt=40kernel.org;=0D=0A>=20devicetree=40vger.kernel=
.org;=20linux-scsi=40vger.kernel.org=0D=0A>=20Cc:=20krzk=40kernel.org;=20av=
ri.altman=40wdc.com;=20martin.petersen=40oracle.com;=0D=0A>=20kwmad.kim=40s=
amsung.com;=20stanley.chu=40mediatek.com;=0D=0A>=20cang=40codeaurora.org;=
=20linux-samsung-soc=40vger.kernel.org;=20linux-arm-=0D=0A>=20kernel=40list=
s.infradead.org;=20linux-kernel=40vger.kernel.org=0D=0A>=20Subject:=20Re:=
=20=5BPATCH=20v4=205/5=5D=20arm64:=20dts:=20Add=20node=20for=20ufs=20exynos=
7=0D=0A>=20=0D=0A>=20On=20Fri,=202020-03-27=20at=2022:36=20+0530,=20Alim=20=
Akhtar=20wrote:=0D=0A>=20>=20Adding=20dt=20node=20foe=20UFS=20and=20UFS-PHY=
=20for=20exynos7=20SoC.=0D=0A>=20>=0D=0A>=20>=20Signed-off-by:=20Alim=20Akh=
tar=20<alim.akhtar=40samsung.com>=0D=0A>=20>=20---=0D=0A>=20>=20=20.../boot=
/dts/exynos/exynos7-espresso.dts=20=20=20=20=20=20=7C=2016=20+++++++=0D=0A>=
=20>=20=20arch/arm64/boot/dts/exynos/exynos7.dtsi=20=20=20=20=20=20=20=7C=
=2043=20++++++++++++++++++-=0D=0A>=20>=20=202=20files=20changed,=2057=20ins=
ertions(+),=202=20deletions(-)=0D=0A>=20>=0D=0A>=20>=20diff=20--git=20a/arc=
h/arm64/boot/dts/exynos/exynos7-espresso.dts=0D=0A>=20>=20b/arch/arm64/boot=
/dts/exynos/exynos7-espresso.dts=0D=0A>=20>=20index=207af288fa9475..b59a0a3=
2620a=20100644=0D=0A>=20>=20---=20a/arch/arm64/boot/dts/exynos/exynos7-espr=
esso.dts=0D=0A>=20>=20+++=20b/arch/arm64/boot/dts/exynos/exynos7-espresso.d=
ts=0D=0A>=20>=20=40=40=20-406,6=20+406,22=20=40=40=0D=0A>=20>=20=20=09=7D;=
=0D=0A>=20>=20=20=7D;=0D=0A>=20>=0D=0A>=20>=20+&ufs=20=7B=0D=0A>=20>=20+=09=
status=20=3D=20=22okay=22;=0D=0A>=20>=20+=09pinctrl-names=20=3D=20=22defaul=
t=22;=0D=0A>=20>=20+=09pinctrl-0=20=3D=20<&ufs_rst_n=20&ufs_refclk_out>;=0D=
=0A>=20>=20+=09ufs,pwr-attr-mode=20=3D=20=22FAST=22;=0D=0A>=20>=20+=09ufs,p=
wr-attr-lane=20=3D=20<2>;=0D=0A>=20>=20+=09ufs,pwr-attr-gear=20=3D=20<2>;=
=0D=0A>=20>=20+=09ufs,pwr-attr-hs-series=20=3D=20=22HS_rate_b=22;=0D=0A>=20=
>=20+=09ufs-rx-adv-fine-gran-sup_en=20=3D=20<1>;=0D=0A>=20>=20+=09ufs-rx-ad=
v-fine-gran-step=20=3D=20<3>;=0D=0A>=20>=20+=09ufs-rx-adv-min-activate-time=
-cap=20=3D=20<9>;=0D=0A>=20>=20+=09ufs-pa-granularity=20=3D=20<6>;=0D=0A>=
=20>=20+=09ufs-pa-tacctivate=20=3D=20<3>;=0D=0A>=20>=20+=09ufs-pa-hibern8ti=
me=20=3D=20<20>;=0D=0A>=20>=20+=7D;=0D=0A>=20>=20+=0D=0A>=20>=20=20&usbdrd_=
phy=20=7B=0D=0A>=20>=20=20=09vbus-supply=20=3D=20<&usb30_vbus_reg>;=0D=0A>=
=20>=20=20=09vbus-boost-supply=20=3D=20<&usb3drd_boost_5v>;=20diff=20--git=
=0D=0A>=20>=20a/arch/arm64/boot/dts/exynos/exynos7.dtsi=0D=0A>=20>=20b/arch=
/arm64/boot/dts/exynos/exynos7.dtsi=0D=0A>=20>=20index=205558045637ac..9d16=
c90edd07=20100644=0D=0A>=20>=20---=20a/arch/arm64/boot/dts/exynos/exynos7.d=
tsi=0D=0A>=20>=20+++=20b/arch/arm64/boot/dts/exynos/exynos7.dtsi=0D=0A>=20>=
=20=40=40=20-220,9=20+220,14=20=40=40=0D=0A>=20>=20=20=09=09=09=23clock-cel=
ls=20=3D=20<1>;=0D=0A>=20>=20=20=09=09=09clocks=20=3D=20<&fin_pll>,=20<&clo=
ck_top1=0D=0A>=20DOUT_ACLK_FSYS1_200>,=0D=0A>=20>=20=20=09=09=09=09=20<&clo=
ck_top1=20DOUT_SCLK_MMC0>,=0D=0A>=20>=20-=09=09=09=09=20<&clock_top1=20DOUT=
_SCLK_MMC1>;=0D=0A>=20>=20+=09=09=09=09=20<&clock_top1=20DOUT_SCLK_MMC1>,=
=0D=0A>=20>=20+=09=09=09=09=20<&clock_top1=20DOUT_SCLK_UFSUNIPRO20>,=0D=0A>=
=20>=20+=09=09=09=09=20<&clock_top1=20DOUT_SCLK_PHY_FSYS1>,=0D=0A>=20>=20+=
=09=09=09=09=20<&clock_top1=20DOUT_SCLK_PHY_FSYS1_26M>;=0D=0A>=20>=20=20=09=
=09=09clock-names=20=3D=20=22fin_pll=22,=20=22dout_aclk_fsys1_200=22,=0D=0A=
>=20>=20-=09=09=09=09=20=20=20=20=20=20=22dout_sclk_mmc0=22,=20=22dout_sclk=
_mmc1=22;=0D=0A>=20>=20+=09=09=09=09=20=20=20=20=20=20=22dout_sclk_mmc0=22,=
=20=22dout_sclk_mmc1=22,=0D=0A>=20>=20+=09=09=09=09=20=20=20=20=20=20=22dou=
t_sclk_ufsunipro20=22,=0D=0A>=20=22dout_sclk_phy_fsys1=22,=0D=0A>=20>=20+=
=09=09=09=09=20=20=20=20=20=20=22dout_sclk_phy_fsys1_26m=22;=0D=0A>=20>=20=
=20=09=09=7D;=0D=0A>=20>=0D=0A>=20>=20=20=09=09serial_0:=20serial=401363000=
0=20=7B=0D=0A>=20>=20=40=40=20-601,6=20+606,40=20=40=40=0D=0A>=20>=20=20=09=
=09=09=7D;=0D=0A>=20>=20=20=09=09=7D;=0D=0A>=20>=0D=0A>=20>=20+=09=09ufs:=
=20ufs=4015570000=20=7B=0D=0A>=20>=20+=09=09=09compatible=20=3D=20=22samsun=
g,exynos7-ufs=22;=0D=0A>=20>=20+=09=09=09=23address-cells=20=3D=20<1>;=0D=
=0A>=20>=20+=09=09=09=23size-cells=20=3D=20<1>;=0D=0A>=20>=20+=09=09=09rang=
es;=0D=0A>=20>=20+=09=09=09reg=20=3D=20<0x15570000=200x100>,=20=20/*=200:=
=20HCI=20standard=20*/=0D=0A>=20>=20+=09=09=09=09<0x15570100=200x100>,=20=
=20/*=201:=20Vendor=20specificed=0D=0A>=20*/=0D=0A>=20>=20+=09=09=09=09<0x1=
5571000=200x200>,=20=20/*=202:=20UNIPRO=20*/=0D=0A>=20>=20+=09=09=09=09<0x1=
5572000=200x300>;=20=20/*=203:=20UFS=20protector=20*/=0D=0A>=20>=20+=09=09=
=09reg-names=20=3D=20=22hci=22,=20=22vs_hci=22,=20=22unipro=22,=20=22ufsp=
=22;=0D=0A>=20>=20+=09=09=09interrupts=20=3D=20<GIC_SPI=20200=20IRQ_TYPE_LE=
VEL_HIGH>;=0D=0A>=20>=20+=09=09=09clocks=20=3D=20<&clock_fsys1=20ACLK_UFS20=
_LINK>,=0D=0A>=20>=20+=09=09=09=09<&clock_fsys1=20SCLK_UFSUNIPRO20_USER>;=
=0D=0A>=20>=20+=09=09=09clock-names=20=3D=20=22core_clk=22,=20=22sclk_unipr=
o_main=22;=0D=0A>=20>=20+=09=09=09freq-table-hz=20=3D=20<0=200>,=20<0=200>;=
=0D=0A>=20>=20+=09=09=09pclk-freq-avail-range=20=3D=20<70000000=20133000000=
>;=0D=0A>=20>=20+=09=09=09ufs,pwr-local-l2-timer=20=3D=20<8000=2028000=2020=
000>;=0D=0A>=20>=20+=09=09=09ufs,pwr-remote-l2-timer=20=3D=20<12000=2032000=
=2016000>;=0D=0A>=20>=20+=09=09=09phys=20=3D=20<&ufs_phy>;=0D=0A>=20>=20+=
=09=09=09phy-names=20=3D=20=22ufs-phy=22;=0D=0A>=20>=20+=09=09=09status=20=
=3D=20=22disabled=22;=0D=0A>=20>=20+=09=09=7D;=0D=0A>=20>=20+=0D=0A>=20>=20=
+=09=09ufs_phy:=20ufs-phy=400x15571800=20=7B=0D=0A>=20>=20+=09=09=09compati=
ble=20=3D=20=22samsung,exynos7-ufs-phy=22;=0D=0A>=20>=20+=09=09=09reg=20=3D=
=20<0x15571800=200x240>;=0D=0A>=20>=20+=09=09=09reg-names=20=3D=20=22phy-pm=
a=22;=0D=0A>=20>=20+=09=09=09samsung,pmu-syscon=20=3D=20<&pmu_system_contro=
ller>;=0D=0A>=20>=20+=09=09=09=23phy-cells=20=3D=20<0>;=0D=0A>=20>=20+=09=
=09=09clocks=20=3D=20<&clock_fsys1=20MOUT_FSYS1_PHYCLK_SEL1>,=0D=0A>=20>=20=
+=09=09=09=09<&clock_top1=20CLK_SCLK_PHY_FSYS1_26M>;=0D=0A>=20>=20+=09=09=
=09clock-names=20=3D=20=22ref_clk_parent=22,=20=22ref_clk=22;=0D=0A>=20Hi=
=0D=0A>=20Is=20this=20correct=20(aren't=20child=20and=20parent=20clock=20sw=
apped)?=0D=0A>=20This=20will=20set=20MOUT_FSYS1_PHYCLK_SEL1=20to=20be=20par=
ent=20clock=20of=0D=0A>=20CLK_SCLK_PHY_FSYS1_26M.=0D=0A=0D=0ALooks=20like=
=20in=20one=20of=20my=20rebase=20it=20got=20swap,=20will=20correct=20it.=20=
=20Thanks=20for=20pointing=20out.=0D=0A=0D=0A>=20I've=20tested=20this=20on=
=20Exynos7420=20(which=20looks=20like=20can=20use=20the=20same=20clock=20dr=
iver=20as=0D=0A>=20exynos7)=20and=20after=20adding=20some=20debug=20code=20=
(because=20currently=20we're=20not=0D=0A>=20handling=20result=20of=20samsun=
g_ufs_phy_clks_init)=20i=20got=0D=0A>=20=0D=0A>=20samsung-ufs-phy=201557180=
0.ufs-phy:=20clk_set_parent=20result:=20-22=0D=0A>=20=0D=0AI=20will=20check=
=20if=20I=20overlooked=20this=20error.=0D=0A>=20On=20vendor=20sources=20for=
=20this=20device,=20driver=20was=20setting=20CLK_SCLK_PHY_FSYS1_26M=0D=0A>=
=20to=20be=20parent=20of=20MOUT_FSYS1_PHYCLK_SEL1,=20and=20then=20it=20did=
=20run=20without=20error.=0D=0A>=20=0D=0A>=20samsung-ufs-phy=2015571800.ufs=
-phy:=20clk_set_parent=20result:=200=0D=0A>=20=0D=0AWith=20this=20change,=
=20does=20linkup=20worked=20for=20you?=0D=0A=0D=0A>=20Also=20looking=20at=
=20clk-exynos7=20driver=20seems=20to=20confirm=20this.=0D=0A>=20=0D=0A>=20>=
=20+=09=09=7D;=0D=0A>=20>=20+=0D=0A>=20>=20=20=09=09usbdrd_phy:=20phy=40155=
00000=20=7B=0D=0A>=20>=20=20=09=09=09compatible=20=3D=20=22samsung,exynos7-=
usbdrd-phy=22;=0D=0A>=20>=20=20=09=09=09reg=20=3D=20<0x15500000=200x100>;=
=0D=0A=0D=0A=0D=0A