Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp774986ybb; Sat, 28 Mar 2020 09:46:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vttas1Khb26NfKmk7J3fuIEGUHteikY1LR3vXvrAuixzrhfNnSLXMYSPZJ2ae9drhx7b9ux X-Received: by 2002:aca:bd0b:: with SMTP id n11mr2697027oif.90.1585413968891; Sat, 28 Mar 2020 09:46:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585413968; cv=none; d=google.com; s=arc-20160816; b=r5JaYKmrTs+YI+piDvf6mYo94MJ97auQL3pI3fVEQzaKJVY15zOSfsfA8q9Ocsxyul LKhBGnnrLOmw6hbPrz9NbiP2ycTAUc3yD26D5WoOUBeoOnXhASrRKNbyp8TbhtQiBqdC IHZ8C0st7s2XfacftyJkil1+ulxrBlV5GeW5PvSdB1ph4jx7ryIJL0ro+V+O63FJWRVr 07N6aXK/xdDMuhe5Nn2veUMeiwUbx6F5uIgiEhqHCaXAHutiOsh3sxUomK6YpTT3FuGk qo5Ya4RFm9e/JIE7e9qrPBD6RQS9tQZXWlFNDyenoMpjE3UY3vAKSb1RGydwVZEWfMNN H/Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:date:from:message-id; bh=COz5m/83OmkXkxGcOreK3zOb6Jj6ulUOeOxoQklCu84=; b=h3LuOsmAQo+XwE4lQLarW7iN6tczhhGtfsS1yGEIxL3JjVK3RLj2pt6dIsMwWJMEQb zvzwRS1SCJiehj0qkahFKbbLdlHmmpltgXHHf3M8VBd4qmGeEhHn4kFa3YiOAigXhoIx H6DXVHxWNx+07pwg7tS7gSOJxzF8g/QhunDFMthntRTD/IVAalesMMM83QPnP/cGo0ZL 3sJi985w9akb+nrp/TesdHg/rRAxu4fZUAlH10w8lfhAXCl7mtWeeAfbxskJNBfA1W9M C46kw7cA8kZeBRJNCXRZAgUbmfS8zNECd28Sjrp6LvtjJCjqGQ+85Eer0D6tkVBWGM+i qp3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si3833714oif.149.2020.03.28.09.45.56; Sat, 28 Mar 2020 09:46:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgC1Qnu (ORCPT + 99 others); Sat, 28 Mar 2020 12:43:50 -0400 Received: from mx.sdf.org ([205.166.94.20]:50019 "EHLO mx.sdf.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbgC1Qnc (ORCPT ); Sat, 28 Mar 2020 12:43:32 -0400 Received: from sdf.org (IDENT:lkml@sdf.lonestar.org [205.166.94.16]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 02SGhEg3025206 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 28 Mar 2020 16:43:14 GMT Received: (from lkml@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 02SGhES8009024; Sat, 28 Mar 2020 16:43:14 GMT Message-Id: <202003281643.02SGhES8009024@sdf.org> From: George Spelvin Date: Mon, 18 Mar 2019 14:56:15 -0400 Subject: [RFC PATCH v1 20/50] lib/random32: Move prandom_warmup() inside prandom_seed_early() To: linux-kernel@vger.kernel.org, lkml@sdf.org Cc: Daniel Borkmann , Stephen Hemminger , Hannes Frederic Sowa Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org They're always called as a pair, so shrink the code. Also, unrolling prandom_warmup() is just a waste of code space. Write it as a loop. Signed-off-by: George Spelvin Cc: Daniel Borkmann Cc: Stephen Hemminger Cc: Hannes Frederic Sowa --- lib/random32.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/lib/random32.c b/lib/random32.c index fc369f4e550c2..340696decc3bb 100644 --- a/lib/random32.c +++ b/lib/random32.c @@ -138,17 +138,10 @@ EXPORT_SYMBOL(prandom_bytes); static void prandom_warmup(struct rnd_state *state) { + int i; /* Calling RNG ten times to satisfy recurrence condition */ - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); - prandom_u32_state(state); + for (i = 0; i < 10; i++) + prandom_u32_state(state); } static u32 __extract_hwseed(void) @@ -170,6 +163,7 @@ static void prandom_seed_early(struct rnd_state *state, u32 seed, state->s2 = __seed(HWSEED() ^ LCG(state->s1), 8U); state->s3 = __seed(HWSEED() ^ LCG(state->s2), 16U); state->s4 = __seed(HWSEED() ^ LCG(state->s3), 128U); + prandom_warmup(state); } /** @@ -209,7 +203,6 @@ static int __init prandom_init(void) u32 weak_seed = (i + jiffies) ^ random_get_entropy(); prandom_seed_early(state, weak_seed, true); - prandom_warmup(state); } return 0; @@ -433,7 +426,6 @@ static void __init prandom_state_selftest(void) struct rnd_state state; prandom_seed_early(&state, test1[i].seed, false); - prandom_warmup(&state); if (test1[i].result != prandom_u32_state(&state)) error = true; @@ -448,7 +440,6 @@ static void __init prandom_state_selftest(void) struct rnd_state state; prandom_seed_early(&state, test2[i].seed, false); - prandom_warmup(&state); for (j = 0; j < test2[i].iteration - 1; j++) prandom_u32_state(&state); -- 2.26.0