Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp776238ybb; Sat, 28 Mar 2020 09:48:01 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs7qXhKlh/WUjFj467pqH4VBzbsMggnVz7HgKshdf8aR0h9TTJsIsN+5cGIrIhxED88Q11E X-Received: by 2002:a9d:f05:: with SMTP id 5mr3146579ott.263.1585414081476; Sat, 28 Mar 2020 09:48:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585414081; cv=none; d=google.com; s=arc-20160816; b=XB9m2CGouxoq15UWAJ8RHB0xZR3uLlg9LX0yVm9TjBbqLdV1GA7C5hnY17tboMtE/Z j0uYOwfLKZlNgMcVnNDLs5QfNWz6FdTDz5jwbGI0jQ4q57GcNLE5Wqcw0Tr+sbmAVDko bEvCD96doD71XIFtUZO7TscT47RJY05W0rY87ISJxLOGEbzGIpm+bKjJ8CIj0zlshd6r DnkhUtWTMRKsD1JrIf4gHw1l0dTfe/6G7fFACQb27dFrSVEhj0BGnPsCaBWT1M4DHEQU nRj8bQel4EhemutDZtA2f4ECo4MI8FsdAc6zinQEmAZz0pXrsurJ6aXsQW/IBbv8cg4w waKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:date:from:message-id; bh=1SWrVDx2z0kuhUzHuWXxWDv+RNHF7ZfzAo1OY6LoSPs=; b=pdlq9pu6QvGExHsNGWoTNHpTN69YqbIsHg4XORhYsT3Pykj3IQaIHXb2C6bJc6GOqr GHfTFRWRyCBBoEiym13dxExjjhmX13KVZhDSGF/2Dw0JS09mSVgWeOwVyvrPmIXnAPT2 9F4IMaTPoEbg1IHH+GiDYaoGHMl4Y+mWDjlpN27TxXwBoUfLLXwT3uyrS0Gf0O8Lum/g 672x6kjlTgHw37ijC0pPYFXaDk+gOLFQFEgk7supHTBpxtO2CyOB4+HXFe3UlS99iIyB P1UMOQfp+E8pQlJ/thIYnztKz86wzEVTCw1VD7w98tlUxzsiwQVXsDQnANEO57BwSP+U bTxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si3617576oie.70.2020.03.28.09.47.49; Sat, 28 Mar 2020 09:48:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgC1QqG (ORCPT + 99 others); Sat, 28 Mar 2020 12:46:06 -0400 Received: from mx.sdf.org ([205.166.94.20]:50095 "EHLO mx.sdf.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727635AbgC1Qn1 (ORCPT ); Sat, 28 Mar 2020 12:43:27 -0400 Received: from sdf.org (IDENT:lkml@sdf.lonestar.org [205.166.94.16]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 02SGhJns017800 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 28 Mar 2020 16:43:19 GMT Received: (from lkml@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 02SGhJ8Y024747; Sat, 28 Mar 2020 16:43:19 GMT Message-Id: <202003281643.02SGhJ8Y024747@sdf.org> From: George Spelvin Date: Fri, 29 Nov 2019 16:44:33 -0500 Subject: [RFC PATCH v1 31/50] lib/nodemask.c: Use cheaper prandom_u32_max() in node_random() To: linux-kernel@vger.kernel.org, lkml@sdf.org Cc: Michal Hocko , Mel Gorman Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function is to spread things around uniformly; cryptographic unguessability is not required. Signed-off-by: George Spelvin Cc: Michal Hocko Cc: Mel Gorman --- lib/nodemask.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nodemask.c b/lib/nodemask.c index 3aa454c54c0de..330f9c7d3da97 100644 --- a/lib/nodemask.c +++ b/lib/nodemask.c @@ -25,7 +25,7 @@ int node_random(const nodemask_t *maskp) w = nodes_weight(*maskp); if (w) bit = bitmap_ord_to_pos(maskp->bits, - get_random_int() % w, MAX_NUMNODES); + prandom_u32_max(w), MAX_NUMNODES); return bit; } #endif -- 2.26.0