Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp891589ybb; Sat, 28 Mar 2020 12:41:03 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt4m+hSPNZcaZKXKf/3dLNGI1fXHey/ttRC1+kagT0omTFji9ZNk8md4O6o2C1cagLdCwYj X-Received: by 2002:a9d:5888:: with SMTP id x8mr3526525otg.361.1585424463842; Sat, 28 Mar 2020 12:41:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585424463; cv=none; d=google.com; s=arc-20160816; b=WthpTo6nRu25Lktc95GcTs+hXnVGlcWhlr35JSml/O2msfWdGkOqkF2G6lmMMYjbQI Kl9bzeYHzC6/wCpwauyo8HKu2bX4HdOCwhB09JB2n2sMA3DWtsiECwldMDl3LZN/Szgn O7dc2IJFrY4aIuJQqCu5mPkciNa5q/RZ/BUGK9gsAL52fvYVIP5BYT7EZI22/mPB2tyq xo6ALboLKU41uCB2M8zryHvXTY1R+D0/n6NedL1R3nVIvdd14wU6S2apwNK0DwWaEHhF S7FBvJ6eH0k3DvvDYsjRiBv4p0mwkpqOhqh/WZcznuDE8F2vkhBXjb9FOS4OGvF/LcwG OzAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=PRrvzwGOTQcyo0gJEgOngIkde3xzMvFhw80XFl+/y2s=; b=XV+Pact6bTmP4NXRYCRFCkGapfT4e5r0tG5+91h0yfLXY3F1y+IAoEZrWKwCpauHc0 JUuJBBtwqXS+MCg5a3RkfEQMsOX2v6BgEJo+qUf7LDXhounGXk742e2pVPMRWMErOeXu wZEpF14IadOxpDSSzjO6/gjirXNAeWNhoZWeoDsvPLwHqbGwDt7dmjHbQqF8ESJY/5e3 DKObUApm5BZfVtIkP5eWZtl1TMwsm1zyEdKGqkWBGs+sJJ9BEc0xtkZUQNW3soZax5Pm PwTQy3hLEGgECAViXE3Qz5rbtR8+UmOfSI4ZheMXb3yzjs1YpHUhqpSFw8F/tgajl4zf 3fTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v22si3903892oic.271.2020.03.28.12.40.50; Sat, 28 Mar 2020 12:41:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgC1TkM (ORCPT + 99 others); Sat, 28 Mar 2020 15:40:12 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42918 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgC1TkM (ORCPT ); Sat, 28 Mar 2020 15:40:12 -0400 Received: by mail-pf1-f195.google.com with SMTP id 22so6377665pfa.9; Sat, 28 Mar 2020 12:40:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=PRrvzwGOTQcyo0gJEgOngIkde3xzMvFhw80XFl+/y2s=; b=iw7vM2BtJ6MY1pB1e/JEKj6vy/L4q8dy2SG6qFbvmNrYu6WZJC4IIpdM890itiFZQu 9YK++nrlw16lGbALHMUmjrVDW9PGzS27lhcs57dol+ogN2+1CEppQ68uu88E2AAi6oOa Yr9n7DQ5DASkZ1MWWbJr3QfX01X2SkZeQqSonnE2zPhqI37BHCKS1dD9b7Bq3cEjbJ0z 0SKcUlSoD5eXYwm0TbG8AdWc2X80tjhfWiLNyaBrPYH2LMnMRoEEb9qkh2c25WKj+1bB AlnL7E08w7Whw8KcLJWfDY3y6THQD9hhydnlqZcU1eyjHubUsXBztrfc/hSo6bpxIBm9 Lfng== X-Gm-Message-State: ANhLgQ3bIJfQiuS0PsYBWprzcqi76MGWIbhOEYOdL7Xbq2k/ltLwFTB2 D9L2hTHR+uVh0orF13iM3SS7cSNGgP4= X-Received: by 2002:aa7:9839:: with SMTP id q25mr5484514pfl.2.1585424410912; Sat, 28 Mar 2020 12:40:10 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:597d:a863:13de:4665? ([2601:647:4000:d7:597d:a863:13de:4665]) by smtp.gmail.com with ESMTPSA id q6sm6327425pja.34.2020.03.28.12.40.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2020 12:40:10 -0700 (PDT) Subject: Re: [PATCH v11 25/26] block/rnbd: a bit of documentation To: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org Cc: axboe@kernel.dk, hch@infradead.org, sagi@grimberg.me, leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca, danil.kipnis@cloud.ionos.com, rpenyaev@suse.de, pankaj.gupta@cloud.ionos.com, linux-kernel@vger.kernel.org References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com> <20200320121657.1165-26-jinpu.wang@cloud.ionos.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <619d2dda-3c4e-a909-ab78-1201057b542c@acm.org> Date: Sat, 28 Mar 2020 12:40:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200320121657.1165-26-jinpu.wang@cloud.ionos.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-20 05:16, Jack Wang wrote: > +RNBD (RDMA Network Block Device) is a pair of kernel modules > +(client and server) that allow for remote access of a block device on > +the server over RTRS protocol using the RDMA (InfiniBand, RoCE, iWarp) ^^^^^ Isn't this protocol usually spelled as iWARP? See also https://en.wikipedia.org/wiki/IWARP. > +dev_search_path option can also contain %SESSNAME% in order to provide > +different deviec namespaces for different sessions. See "device_path" ^^^^^^ device? > +option for details. Otherwise this patch looks fine to me. Hence: Reviewed-by: Bart Van Assche