Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1034958ybb; Sat, 28 Mar 2020 16:44:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuglIcVO58TCp/bQCeacBtPMnw0iTqqsFovqiuRPH1H1p5eiVXOmeVyIabUOTwINZ58cAUR X-Received: by 2002:a05:6830:1046:: with SMTP id b6mr4459977otp.229.1585439042460; Sat, 28 Mar 2020 16:44:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585439042; cv=none; d=google.com; s=arc-20160816; b=kML2RSd9UnrPmQzYM4bC/NqgPtyCvxlVv8a3FGMm6e8bbXhZoaTHYJFJwwMlpdFmO7 bt1ivXCAK+rzSM6GEeMzD/TGpNKeNVXHzVT5DGg7oAA0fXCZ/ACNUXeoOzUMBo6jUlOs rfyMEWp4qc5EbVz1PO22KhirdrwYkLdBmfzF4HrjhWL9NTqlUE6cLTBtg8zQE9sW4Bpj lu6vLqkKqbLwlwB2exm9k+WmQe7U/Z1Rq/HACQ9lARJmH1bUGQvMvF+oyUiw1pySSOrZ X0RqY7/0fsoaMez8RIvAvuQFWSrmKINQjKXPuXpo+E08Ar4dCg+Xl/jLSNMu7tTaIKdk vLQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Dhcv2UKcfUz51LaTKTzJ9NAVcH7SHyw6ynwc3Ig8y0w=; b=YIV6r8tATi0Dw3hE9Nq2gsVlYtMJeMZENZUH4adWDlG0y9ZxjD3YXQ4iVdlp3isx0p rwhKsCSNZUYuDrBLm8zGed3Pn5otA0yTCxEJ0HZWokT4VjV/+ONKQUrQYcfMN2WaqghW JSl+JSwAkeucLxfqiJ4tLiHXow0qmnknWxYVW4hHdzjDH5DB/1L+Smwf98cC+ZGnDUgy E2LU7vT6PukJcV7TE7iA2/0tY4hBMGbkA36wrAtS7JZvF4z9sxhNcwUMlldQKUVmNQhC 0OKQJMKXYGr8hZXN56l3+RWThqdKLaqHikUazkXpt8BtFXxJunsOS5CpupC6PqcB1WxC Z1tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWqeW4By; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t193si4142750oih.61.2020.03.28.16.43.49; Sat, 28 Mar 2020 16:44:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWqeW4By; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbgC1XnI (ORCPT + 99 others); Sat, 28 Mar 2020 19:43:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:41314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbgC1XnH (ORCPT ); Sat, 28 Mar 2020 19:43:07 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1555920716; Sat, 28 Mar 2020 23:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585438987; bh=8F71ls7LTfaSvQwEnfaxYVz5lj1N1vsQKt2LOAk29EQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=zWqeW4Byiv022nOtsnEbub+KQiNfiX4TOzaJ6hxmErzytUkabLE/2P9exka8iqCHN SPWVGFClHCkP6cjo2UcQfAb4cdsKf5ARgo/kGQ85eNQiQfjuLkDAcwW8laqylZYJT/ RtS8GRPH5BHMybeHXQD3p4LJAjcsBwZ04ud9Bpac= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 979A83522755; Sat, 28 Mar 2020 16:43:06 -0700 (PDT) Date: Sat, 28 Mar 2020 16:43:06 -0700 From: "Paul E. McKenney" To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Frederic Weisbecker , frextrite@gmail.com, Ingo Molnar , Josh Triplett , kernel-team@android.com, Lai Jiangshan , madhuparnabhowmik04@gmail.com, Mathieu Desnoyers , peterz@infradead.org, Petr Mladek , rcu@vger.kernel.org, rostedt@goodmis.org, tglx@linutronix.de, vpillai@digitalocean.com Subject: Re: [PATCH v2 0/4] RCU dyntick nesting counter cleanups Message-ID: <20200328234306.GC19865@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200328221703.48171-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200328221703.48171-1-joel@joelfernandes.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 28, 2020 at 06:16:59PM -0400, Joel Fernandes (Google) wrote: > These patches clean up the usage of dynticks nesting counters simplifying the > code, while preserving the usecases. > > It is a much needed simplification, makes the code less confusing, and prevents > future bugs such as those that arise from forgetting that the > dynticks_nmi_nesting counter is not a simple counter and can be "crowbarred" in > common situations. > > rcutorture testing with all TREE RCU configurations succeed with > CONFIG_RCU_EQS_DEBUG=y and CONFIG_PROVE_LOCKING=y. Heh! We now have a three-way collision between Thomas's and Peter's series, the RCU Tasks Trace series, and this series. ;-) Remind me once v5.7-rc1 comes out and let's see what fits where. Thanx, Paul > v1->v2: > - Rebase on v5.6-rc6 > > Joel Fernandes (Google) (4): > Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of > ->dynticks counter") > rcu/tree: Add better tracing for dyntick-idle > rcu/tree: Clean up dynticks counter usage > rcu/tree: Remove dynticks_nmi_nesting counter > > .../Data-Structures/Data-Structures.rst | 31 +-- > Documentation/RCU/stallwarn.txt | 6 +- > include/linux/rcutiny.h | 3 - > include/trace/events/rcu.h | 29 +-- > kernel/rcu/rcu.h | 4 - > kernel/rcu/tree.c | 188 +++++++----------- > kernel/rcu/tree.h | 4 +- > kernel/rcu/tree_stall.h | 4 +- > 8 files changed, 105 insertions(+), 164 deletions(-) > > -- > 2.26.0.rc2.310.g2932bb562d-goog >