Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1043684ybb; Sat, 28 Mar 2020 17:00:19 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsH5uFKJPs/mhFa/7SRYGU574gqRh3qrazP8Ghjk8uKuxYJO/+woy9m8FfbwVYHDdtYX9hI X-Received: by 2002:a9d:5545:: with SMTP id h5mr4373278oti.323.1585440018861; Sat, 28 Mar 2020 17:00:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585440018; cv=none; d=google.com; s=arc-20160816; b=iCjljajnTjdqU42x/J+YhzVpW0qH8K5HWjLB9poYD4gWmaXQ64fgRQ3Zvalg1MuMIr 84bf28K0lVphrRlW8ZBnyrEulVNSPvXt2+Aa0CnSNfYPwGZTOUeMP75hNbxfnaW+DJhH WQvLpnYIXiv3SHXrwedVtDdryAafzC1HCODIUfoaVKptlR82El96H9FjYwmW2PIrn1iQ YLz29G5baJem6c+UbbBCr86J0VKTcpXS6k856Wud9RMJ0l1e5JlrNHZUWeGcxqsxVaIV J+sdEVsYlA2TvT3cqUfsZiGFKe21Ox0TNIiWrciFB8cVL2L3Ak0gbJj78nRhmEk/ghBd OrZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=q126VLRY+UYUSrmkccqPHR4aNBhpLWfnHaERaQZZBhY=; b=ul3mz+DbchCNEeOwPSHoJaqsJUKBvRM+Eu87KHVwUUOjAZq6M47WlShb7iwyxyCuEu xwLI8/qD6AacXnsdqEsoVrmvu0F++D5qrEe3bkNcsf6FoHmD1e37gfs2V5RiKDaP8qQw WBHw18rzgQZ4Bcvf1csW9p+D8Ovga4F8WoTjX4pVAyxw/UBZWAr6qiaazq6vyRRQh7K1 O8IX21McBjLHg6sevbFVaqWLgyKvkY4W5PwwEP04KInhfe0gV/c3q+h17jkoOT71nmkP s6U55zeLb0qFKpJ7+2lMx3WiBreSwj2Pfai+1mbuMkpwc/tyV2Z6aYO399LDDld6NNHH rpdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=DkvZAGnL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m23si4706393ots.325.2020.03.28.16.59.53; Sat, 28 Mar 2020 17:00:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=DkvZAGnL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727745AbgC1X45 (ORCPT + 99 others); Sat, 28 Mar 2020 19:56:57 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:42766 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbgC1X45 (ORCPT ); Sat, 28 Mar 2020 19:56:57 -0400 Received: by mail-qk1-f193.google.com with SMTP id 139so5297173qkd.9 for ; Sat, 28 Mar 2020 16:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q126VLRY+UYUSrmkccqPHR4aNBhpLWfnHaERaQZZBhY=; b=DkvZAGnLJujojh2FwBe85MPB0oPd0pN2tBx5bDa9wF6RcukHpfkTxndsOeNvB1ywpS 8llx45XFfCgB9Bg4Ma+A+iWfat8arDQpXlyu6wsHoSwkcnK9dT/aY5TZhSRyXwtdKL5i 829zsXWNd7IkMaUz+clKFGtfrhi62uQChc7eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q126VLRY+UYUSrmkccqPHR4aNBhpLWfnHaERaQZZBhY=; b=cnVGbHXXFgPQoQTR+iZSst9QY78NX5F/P5XZfuQyKldGuKUkYmUSCxm77fYx+tSqvz Bdgw+bR/nxdxVuy3KaU/8aNA+SMKc8RLLc7znyK0+5wjgxl8DH7+Ci+sn0SUvf8uPGAF LSko5q5fRcfI2p1txIKCvmTXRQC3D8tRGzKU+MoWE1jx+LV33QR3QxC0AEUgWm/L4tah pL4t8oTTpMEl76LkLfQmXSpLGG6etsUVskOWVD9GAVQvKobS+BfWaZdpjjEd81uhzvRT gK7cHSCDwX181QjbNw91ZHbzXO+OCSw4bIHzwzfq+Uy4ELwHT5VlhquOe9KhJfAqmHTE 0JtA== X-Gm-Message-State: ANhLgQ36XZYw1vjrd1GcNq2QFhgxoUCwFo62XSiVeiAKONTXKyPEbe1F JGFgGl7skUgVS98tg9WrDcHB7w== X-Received: by 2002:a37:634d:: with SMTP id x74mr6046668qkb.254.1585439814210; Sat, 28 Mar 2020 16:56:54 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id r3sm6987044qkd.3.2020.03.28.16.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2020 16:56:53 -0700 (PDT) Date: Sat, 28 Mar 2020 19:56:53 -0400 From: Joel Fernandes To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Frederic Weisbecker , frextrite@gmail.com, Ingo Molnar , Josh Triplett , kernel-team@android.com, Lai Jiangshan , madhuparnabhowmik04@gmail.com, Mathieu Desnoyers , peterz@infradead.org, Petr Mladek , rcu@vger.kernel.org, rostedt@goodmis.org, tglx@linutronix.de, vpillai@digitalocean.com Subject: Re: [PATCH v2 0/4] RCU dyntick nesting counter cleanups Message-ID: <20200328235653.GA69048@google.com> References: <20200328221703.48171-1-joel@joelfernandes.org> <20200328234306.GC19865@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200328234306.GC19865@paulmck-ThinkPad-P72> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 28, 2020 at 04:43:06PM -0700, Paul E. McKenney wrote: > On Sat, Mar 28, 2020 at 06:16:59PM -0400, Joel Fernandes (Google) wrote: > > These patches clean up the usage of dynticks nesting counters simplifying the > > code, while preserving the usecases. > > > > It is a much needed simplification, makes the code less confusing, and prevents > > future bugs such as those that arise from forgetting that the > > dynticks_nmi_nesting counter is not a simple counter and can be "crowbarred" in > > common situations. > > > > rcutorture testing with all TREE RCU configurations succeed with > > CONFIG_RCU_EQS_DEBUG=y and CONFIG_PROVE_LOCKING=y. > > Heh! We now have a three-way collision between Thomas's and Peter's > series, the RCU Tasks Trace series, and this series. ;-) > > Remind me once v5.7-rc1 comes out and let's see what fits where. Ok, no problem, I will resend at 5.7-rc1 time then. I believe I did a lot of the work to make the series catch up with the tip especially after the KCSAN changes, so it should be relatively easy (hopefully) for me to rebase at -rc1. thanks! - Joel > > v1->v2: > > - Rebase on v5.6-rc6 > > > > Joel Fernandes (Google) (4): > > Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of > > ->dynticks counter") > > rcu/tree: Add better tracing for dyntick-idle > > rcu/tree: Clean up dynticks counter usage > > rcu/tree: Remove dynticks_nmi_nesting counter > > > > .../Data-Structures/Data-Structures.rst | 31 +-- > > Documentation/RCU/stallwarn.txt | 6 +- > > include/linux/rcutiny.h | 3 - > > include/trace/events/rcu.h | 29 +-- > > kernel/rcu/rcu.h | 4 - > > kernel/rcu/tree.c | 188 +++++++----------- > > kernel/rcu/tree.h | 4 +- > > kernel/rcu/tree_stall.h | 4 +- > > 8 files changed, 105 insertions(+), 164 deletions(-) > > > > -- > > 2.26.0.rc2.310.g2932bb562d-goog > >