Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Mar 2020 09:45:51 +0200
Message-ID: <s5hpncvd2og.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Rouven Czerwinski <rouven@czerwinskis.de>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: default enable CA0132 DSP support
In-Reply-To: <20200329053710.4276-1-r.czerwinski@pengutronix.de>
References: <20200329053710.4276-1-r.czerwinski@pengutronix.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 29 Mar 2020 07:30:15 +0200,
Rouven Czerwinski wrote:
> 
> From: Rouven Czerwinski <rouven@czerwinskis.de>
> 
> If SND_HDA_CODEC_CA0132 is enabled, the DSP support should be enabled as
> well. Disabled DSP support leads to a hanging alsa system and no sound
> output on the card otherwise. Tested on:
> 
>   06:00.0 Audio device: Creative Labs Sound Core3D [Sound Blaster Recon3D / Z-Series] (rev 01)
> 
> Signed-off-by: Rouven Czerwinski <rouven@czerwinskis.de>

OK, since the DSP support has been improved a lot in comparison with
the early stage, so it makes sense.  I believe most of distros have
set already this to y, and it won't be any big impact.

Applied now.  Thanks.


Takashi