Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1395730ybb; Sun, 29 Mar 2020 03:40:27 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuVNXB4z8DfOaX5D98nxv6aVYjnw3Rz9Mq07n22Atm1Um3F8RvvMS0uIMCai8GGU6sFvkxU X-Received: by 2002:aca:ddc5:: with SMTP id u188mr4247086oig.8.1585478427638; Sun, 29 Mar 2020 03:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585478427; cv=none; d=google.com; s=arc-20160816; b=MrK3uF/lfAPN+RiQ7e3AbVPmF3u+h0mdfblEHTt7HfoG3cw+ZdRVYPFP6j2C1y+RlK axk6w/etCYe33q2W5bCPZ0oTy4oDOA+DF+h5Xz2aw9s6wlZgf/ZoIM07r/SN9/hUHPBR yF12wt4iOuYdCiSXLi9DRpFgEOHLeREPD/2xm1FaDvaTACuJ/hxydemY7g5IrbPJQEmM 1ey7N6WQIx2h9aaIhOXa6fangqdE6M9nA0BHtn+xNAK1BXDZoUS9s1stNptEDJOHCBMa 3LUwMick3dq+Fa7EOn9YHZRQystyRgQ+HnVEVKaGhKGx3RQcdhhgRfPvPX+Om+Lt/B0e /myA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=71RlhCSY8oNNUxnE6bOWCXws7Gp/rPuisSxtRcSLemY=; b=tSs2JclHLl/QG2v7onxGmlcc2SY1VSWHaf6lw9Kl4Nxi0zp69FU6BK2qZJ4JkKBHs4 M0R2++KSvg/1hej6g+khoiy8w7G5oQ8HNdZZ+5O9kCPfkfgZN7llrw4Kh994Gj+DYndZ yxZL9Znl7ufGCZvK/8QXAY4VPLmDFazU71ot2Zd3kmpVi2jeJNwLtq3ianHt0vCmNWet GnGnO+64aIFkpycndKfbiLk8/Ed8oMu49zgusziPByV7IM7eta4QLxIuSW3n9WkzZPQ8 +hvadEGSQnJJolPFXAjignqhkqdZURBymjuBnw8ys0VOnHeHsYulw1FNX1okle47oRBy bopA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YZtvYKa6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si4754514oih.275.2020.03.29.03.40.14; Sun, 29 Mar 2020 03:40:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YZtvYKa6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbgC2Kh6 (ORCPT + 99 others); Sun, 29 Mar 2020 06:37:58 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52314 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbgC2Kh6 (ORCPT ); Sun, 29 Mar 2020 06:37:58 -0400 Received: by mail-wm1-f68.google.com with SMTP id z18so16534300wmk.2; Sun, 29 Mar 2020 03:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=71RlhCSY8oNNUxnE6bOWCXws7Gp/rPuisSxtRcSLemY=; b=YZtvYKa698h+YWJETGtThKPWyClMiN3dTJaekhReiBHmyxVGVuu9cA+QnomoZFeRJC AgocSSl59oiolVhdq5Y4jf8X9+Fazyy54pafM/roUfKuSD9k2NjL067ZKwNESP82WBwC NLphcV1Hr3ETawfKgOGgv8HrKjzGMlVXZtWUvyApPf8mm+x1cTXR3ZYAVtyD83aaN8Yc 97RcdB1QEnincTtBPv+OE9rFfFjVs+Ap5z169xTIUKlIyBQ6pmBzzgRXVt0rpxK24NvA 9Htk6d/NBwCUNyAMnauO1MksLAyIRNtNmP5dCKBOr9TOmmzszwgzNKcUcFvY/FH1sTNQ OaGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=71RlhCSY8oNNUxnE6bOWCXws7Gp/rPuisSxtRcSLemY=; b=tsuYU8Gz7sOaD0Uj9i63ozjlrayQNYS3YMOoJeKZdDdxuhN5AwIM9MXNk7w0TASYsd /j9xSipPwZ5bR39nIMHSzHfhasya8wZYkQ8e4zVDru5TwJaCUxw6VOZG+booOlBY8lza eaIIdPNxSAf3yl5wJ2Xce1GOvBitZTX9iSkPRCn2gFxVouRmLSNxVlk89JZqaCNww64e ubLEmhg5+iIQ3D2JQ5efJkXnLnPM0AWTqMr3RMsBe507q3+IlEzn80aG8ekaPjPyDgUA GJTpBDTOiW61j0LM//IH0Z1IkuqGKHI8U7d7AJMuCDfAQEC44VurNN2At8r9A5KvWlkb DESA== X-Gm-Message-State: ANhLgQ0wmG7vekIxcuIGNEXkg7LPyZ9GMGhjPWL7FVyC1MHKwMfzCvTj po5B7YGkuCErQdhutFff5ievzYoY X-Received: by 2002:a1c:68d5:: with SMTP id d204mr7904068wmc.15.1585478275203; Sun, 29 Mar 2020 03:37:55 -0700 (PDT) Received: from [192.168.0.104] (p5B3F6BD9.dip0.t-ipconnect.de. [91.63.107.217]) by smtp.gmail.com with ESMTPSA id l17sm17383372wrm.57.2020.03.29.03.37.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2020 03:37:54 -0700 (PDT) Subject: Re: [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver To: Jonathan Cameron , Andy Shevchenko Cc: Lee Jones , Rob Herring , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM References: <20200322224626.13160-1-sravanhome@gmail.com> <20200322224626.13160-4-sravanhome@gmail.com> <20200328144234.081b964f@archlinux> From: saravanan sekar Message-ID: Date: Sun, 29 Mar 2020 12:37:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200328144234.081b964f@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 28/03/20 3:42 pm, Jonathan Cameron wrote: > On Mon, 23 Mar 2020 01:32:34 +0200 > Andy Shevchenko wrote: > >> On Mon, Mar 23, 2020 at 12:47 AM Saravanan Sekar wrote: >>> Add support for 8-bit resolution ADC readings for input power >>> supply and battery charging measurement. Provides voltage, current >>> readings to mp2629 power supply driver. >> ... >> >>> +#include >>> +#include >> Don't see users of it. Forgot to reply, its needed since I used struct of_device "error: field name not in record or union initializer   { .compatible = "mps,mp2629_charger"}," >>> +#include >>> +#include >>> +#include >>> +#include >> Any users? >> >>> +#include >> Perhaps ordered? >> >>> +#include >>> +#include >>> +#include >> + blank line? >> >>> +#include >> ... >> >>> +static int mp2629_read_raw(struct iio_dev *indio_dev, >>> + struct iio_chan_spec const *chan, >>> + int *val, int *val2, long mask) >>> +{ >>> + struct mp2629_adc *info = iio_priv(indio_dev); >>> + unsigned int rval; >>> + int ret; >>> + >>> + switch (mask) { >>> + case IIO_CHAN_INFO_RAW: >>> + ret = regmap_read(info->regmap, chan->address, &rval); >>> + if (ret < 0) >>> + return ret; >>> + >>> + if (chan->address == MP2629_INPUT_VOLT) >>> + rval &= 0x7f; >> GENMASK() ? >> >>> + *val = rval; >>> + return IIO_VAL_INT; >>> + return 0; >>> +} >> ... >> >>> + void **pdata = pdev->dev.platform_data; >> Same Qs as per other patch. >> >> ... >> >>> + indio_dev->dev.of_node = pdev->dev.of_node; >> Jonathan, doesn't IIO core do this for all? >> > Nope. I'm not totally sure it's always safe to do so > as we have some weird parent structures in some cases. > A quick grep suggests that we may be fine though, or > alternatively be able to get away with a set it if not > already set approach. > > I'll take a look when I get some time. It would be nice > to clean this up. > > Jonathan > > > >