Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200327223443.6006-1-gwendal@chromium.org> <20200327223443.6006-13-gwendal@chromium.org>
In-Reply-To: <20200327223443.6006-13-gwendal@chromium.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 29 Mar 2020 14:22:11 +0300
Message-ID: <CAHp75VeRZO9DnTRZWavfp2FPjg_kqmpNr0VZnXv1U3G4Pr0iFQ@mail.gmail.com>
Subject: Re: [PATCH v7 12/12] iio: cros_ec: flush as hwfifo attribute
To:     Gwendal Grignou <gwendal@chromium.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 28, 2020 at 12:37 AM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> Add buffer/hwfifo_flush. It is not part of the ABI, but it follows ST
> and HID lead: Tells the sensor hub to send to the host all pending
> sensor events.

I see where discussion is going, but nevertheless some comments below
that you will not make same mistakes in the future.

...

> +       int ret = 0;

Useless assignment.

> +       bool flush;
> +

> +       ret = strtobool(buf, &flush);

kstrtobool()

> +       if (ret < 0)

Positive error codes? I'm not sure it returns a such. So ' < 0' part
is redundant.

> +               return ret;

> +       if (!flush)
> +               return -EINVAL;

This I didn't get, you have accept only true as input? It's really strange.

> +       ret = cros_ec_motion_send_host_cmd(st, 0);

> +       if (ret != 0)

Similar to above ' != 0' part is redundant.

> +               dev_warn(&indio_dev->dev, "Unable to flush sensor\n");

...

> +static IIO_DEVICE_ATTR(hwfifo_flush, 0644, NULL,
> +                      cros_ec_sensors_flush, 0);

IIO_DEVICE_ATTR_RW() ?

-- 
With Best Regards,
Andy Shevchenko