Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1620412ybb; Sun, 29 Mar 2020 09:11:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv5Hn3zMJXXGKge061f1Hf2JbUwkNr9nG9R8nVBFC2taDLDLodbN+vUY/omBE9K40W9YjPL X-Received: by 2002:a05:6830:1f5a:: with SMTP id u26mr6261655oth.208.1585498300111; Sun, 29 Mar 2020 09:11:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585498300; cv=none; d=google.com; s=arc-20160816; b=ksHKIgCvV8sVHKLA86fa1bVxDvwJCcNgOvAuB2Wz4nN1AV0kwszx5g177AtAEhhAcF wYusTs0utuJnP+8onHAtmMvHHwRo68qMWnW97ioxNzoGGZt2qB8pzvoyuWoVPkGkoTqm j64uORKjPFW/C2JreH71zVDxQ0ZHBSZfKX+Rbuul8RzOMOctk70IFxvrsR4ZS88xwAW/ Uam8bVRTzEW2i8fS+HZtLkmNpd+W51K77TEmLLiZOdy/YGPnHb0YA0YPciCW1qH7+uZ7 4Xoztrq+Fv3woBxmXVtKlhGDPRFGPa6a8mGuIIErHyb0XxQabT5oGSvVjyjjb+UNtPQl +pwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=19Szx/bVByD1ghQE1BjAko3auE4LJvT1UW4NfdM+INk=; b=WbQVw2y7RRkfHHPxEq3gOx88eF8LjFOOZORTL7LLLcqHY+X6qQ04djI74Jc5KSAlpe hnNLMBmsc8Qn/i1cH6rdnc4zLHOMOlyKEQz8A81irOvz/yMnlRsKmkmPWYA/b8UcSG7I V57qJkoXMLKE8Oj37slLr6iogcbEXOTlEy8tak2HtJUPG9XaWyRiXyzEyWfWcXSCN52W /EmcS2lVVUcBTCBN8kOR/DIWTmpq0O5JMwJQlQFXNxBtnCPQR+pR61OuIgc5JFVRU1D1 p51MuGugCJ6clXochGKl6c6q0YieZLAEGpnz8EzlArN8DKlZaECzWGkdxMMfse+hXodA cefQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UXmhU7T8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r82si5081814oia.155.2020.03.29.09.11.26; Sun, 29 Mar 2020 09:11:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UXmhU7T8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbgC2QJG (ORCPT + 99 others); Sun, 29 Mar 2020 12:09:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:48942 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728209AbgC2QJG (ORCPT ); Sun, 29 Mar 2020 12:09:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=19Szx/bVByD1ghQE1BjAko3auE4LJvT1UW4NfdM+INk=; b=UXmhU7T8G2RkDxr6KRK+J4nIXw w+T+Nau/44IRWZWA3n6teQCWFV76Xtrrn7hZSP5Wfgld+zZd4EJHxnF4quBm5kxxMtf+T1o5ZTz1V 61bgGK+nJjhajcyxqbbqgjjwO0uO1OsnfWhfXN4rCND3DuroaFBjQZv6HqHMqsKrdOL1lP5ea/NeO 822vbvyK2jc8pb7NDlouQwGjc/+D5aNnjp6ynED5xO9dC66nVoJzvlMchpEjoCFCxs7Eb7f5/8UQY 28s8Jw4IiUW1prNk3RCwd48IuWygocFy9O3C3jlK4Gnm8PZude1vWyXYEN6ZrLKZevFNhhY4ojyTJ Os9ohYkw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIaUc-0007Nx-N8; Sun, 29 Mar 2020 16:08:58 +0000 Date: Sun, 29 Mar 2020 09:08:58 -0700 From: Matthew Wilcox To: Jaewon Kim Cc: walken@google.com, bp@suse.de, akpm@linux-foundation.org, srostedt@vmware.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v3 2/2] mm: mmap: add trace point of vm_unmapped_area Message-ID: <20200329160858.GV22483@bombadil.infradead.org> References: <20200320055823.27089-1-jaewon31.kim@samsung.com> <20200320055823.27089-3-jaewon31.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320055823.27089-3-jaewon31.kim@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2020 at 02:58:23PM +0900, Jaewon Kim wrote: > + TP_printk("addr=%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", Shouldn't addr be printed as 0x%lx? I think it's arguable whether to print len as %ld or 0x%lx.