Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1721959ybb; Sun, 29 Mar 2020 11:43:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsgnnqA+iH8DVC3ieMT2ZRxKZRRnj/+PHs4NTufQY2Y1U9ESXMpwSywWKnGAfxm9JCDnLYq X-Received: by 2002:aca:1e0e:: with SMTP id m14mr1867065oic.136.1585507423341; Sun, 29 Mar 2020 11:43:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585507423; cv=none; d=google.com; s=arc-20160816; b=g1f+yEWfstPAOrEmgQypMG1F0rvX4W+bZJdQ+YZ9vtXYO4s9uQMVoppKBOeZcQ7Sjb wi/+MygUcuruyzAkKkyRAY0S607kTHvozgaveVTXcl+VGsHEembogIxrMGe/c40UIhEm 7Le+fnT9LD5bw3EFKtVAJK1eAwkzxnnKLEYGiPL/Q/X4n8zlgGH+/sQDA+TcrmLPpKUY Y6DK2tTJY/eD8vRyOLyQcALiCUhJ5jTPSAEUWMoB8tctKnfG7Dl7u8Fx9la+lqttpqUO DPg7KHVE7hQHnwOiY39kIHHz4uueCFPnrgeiCKVjmkJW1L3nHKsqXhWaVLh+0j89JqYr PiXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xZgVqb4y2QWgkLb7plXJBf0r4LTT7aqW4Cc9niuX5cs=; b=rN6pg17JPfAVCNcZ/91RyWjRseXgf82Hw5xnEPnj3SoVbpo2yTqm1C6spbDIUE0C+S ZaXdWk7aWDBo+MwTNqhpPR0F9SV9YTAHnD5f2xC2a4R9B3BGfLEBdB5A8e+d80Id2n1j 2w30gb3hvqEyB0ONNjIyHigvJrgf4tTzf5ZCjyosZw49qplxfqZcTBmcC1HlK/fyaZ+c 8HAwA22VB3nzQEALkrv5KjE6SYSFU1rJWaGpC8AVRbXuVp712dxgdsdp74vluJDiW1tB xCmlLY4VKUDoVRJxjdhxJlfHX5s/ETgDTweYjI0ze7uyyDYOvIpJb3ZgN7+xF1eckaus gzeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=X6rjXs8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si5329193otb.312.2020.03.29.11.43.31; Sun, 29 Mar 2020 11:43:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=X6rjXs8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbgC2SUR (ORCPT + 99 others); Sun, 29 Mar 2020 14:20:17 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34881 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727719AbgC2SUQ (ORCPT ); Sun, 29 Mar 2020 14:20:16 -0400 Received: by mail-lj1-f195.google.com with SMTP id k21so15604840ljh.2 for ; Sun, 29 Mar 2020 11:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xZgVqb4y2QWgkLb7plXJBf0r4LTT7aqW4Cc9niuX5cs=; b=X6rjXs8vhB27dDuIHfTaryhJH5+o9Hav/CRHSHFk5SWXqW0GsRuypXAiq0GaFA0Xwn YN4+D58xzljj4iPZCYGyyAibUe7O8eMXu+eRr83DisWp0nLJ5MKuv/Mcz6Sybxmg4Bws 4wMdPGMB9P82xc+iqc2+Te8wAp+7H53dw482s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xZgVqb4y2QWgkLb7plXJBf0r4LTT7aqW4Cc9niuX5cs=; b=b/nP5TSdOfWpj0dAjuCxo6j7G+m0q9EwawUuIr9B1xfGkOmzQjsez8yhk2kQvxcQUw gNLMoiC8MqxsiJV7+0pR4SW1LkJPClo5UTt9EoXzgHWTvJ1IEKG5YAjSZy3yevrvRJCC h+vSL/1QI4MEIZLXs8xCSPV/09/r0odnvgFIjDNJrxqs5Z0cHoZA9G5T3jIiMf7iVCIt JnMabBmEiUexNR+q1PJ7SRlccaeZvzQp9fo17tPoDwDaTxGA48G5ud0BNe9xt4hX+39Y J6QyRYQYnj2QHZZxV1iKFL4lZfwd7Gf1gzDJLp7yHAL0K8JIGkN1NBKCrh1OKc+foif4 snKA== X-Gm-Message-State: AGi0PubwNCiGSTqP5eoWnmS2hXOZuT4V+vXhI0Y9FJogmWOk0gOSm6fp ALTuDE23qoS4LPh7NzK5KixVtopI/mY= X-Received: by 2002:a2e:8084:: with SMTP id i4mr5078821ljg.185.1585506014354; Sun, 29 Mar 2020 11:20:14 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id o4sm6548983lfl.62.2020.03.29.11.20.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2020 11:20:13 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id j17so12122658lfe.7 for ; Sun, 29 Mar 2020 11:20:13 -0700 (PDT) X-Received: by 2002:a19:6144:: with SMTP id m4mr5733869lfk.192.1585506013304; Sun, 29 Mar 2020 11:20:13 -0700 (PDT) MIME-Version: 1.0 References: <20200323183620.GD23230@ZenIV.linux.org.uk> <20200323183819.250124-1-viro@ZenIV.linux.org.uk> <20200328104857.GA93574@gmail.com> <20200328115936.GA23230@ZenIV.linux.org.uk> <20200329092602.GB93574@gmail.com> <489c9af889954649b3453e350bab6464@AcuMS.aculab.com> <20200329181627.GD23230@ZenIV.linux.org.uk> In-Reply-To: <20200329181627.GD23230@ZenIV.linux.org.uk> From: Linus Torvalds Date: Sun, 29 Mar 2020 11:19:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC][PATCH 01/22] x86 user stack frame reads: switch to explicit __get_user() To: Al Viro Cc: David Laight , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , X86 ML , LKML , Borislav Petkov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 29, 2020 at 11:18 AM Al Viro wrote: > > Except that you'd better make that > if (!user_access_begin(...)) > return -EFAULT; Yeah, that should teach me not to just write random code snippets in the mail reader rather than just cutting-and-pasting actual working code ;) Linus