Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Mar 2020 18:40:06 +0000
From:   Roger Gammans <rgammans@gammascience.co.uk>
To:     Sandeep Singh <Sandeep.Singh@amd.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
Subject: Re: [PATCH v4 4/4] SFH: Create HID report to Enable support of AMD
 sensor fusion Hub (SFH)
Message-ID: <20200329184006.GA8199@kilburn.gammascience.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 27, 2020 at 05:10:57AM +0000, Sandeep Singh wrote:

> From: Sandeep Singh <sandeep.singh@amd.com>
> 
> +#include "amd_sfh_hid_report_descriptor.h"
> +#include "amd_mp2_pcie.h"

I had to change the last line to 

  #include "../amd_mp2_pcie.h"

to make it compile out of tree. After that I got a clean compile.

Also I don't seem to be getting any data through
to monitor-sensor in user space when I do install it, but I am
gettting logs of log messages similar to this:

 pcie_mp2_amd 0000:04:00.7: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000c address=0x5267f000 flags=0x0020]
 pcie_mp2_amd 0000:04:00.7: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000c address=0x5267f000 flags=0x0020]

This is compiled against the debian 5.4.0 kernel, on a
     HP ENVY x360 Convertible 15-ds0xxx, SKU 6TD07EA#ABU

I can run other tests or try other kernels if you think it might help,
let me know what you need.

-- 
Roger Gammans