Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1951890ybb; Sun, 29 Mar 2020 18:07:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuhND4Il9H+7UgKvEHZQJTzWDHkmpl9huQgc2PAyEFvzYgYw2xCTgh15SwWaKaejZOn2BJt X-Received: by 2002:a05:6830:1dfa:: with SMTP id b26mr7113238otj.13.1585530435217; Sun, 29 Mar 2020 18:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585530435; cv=none; d=google.com; s=arc-20160816; b=pFuNwDG4Au8YEryZuAB9Zmogq3h97VbKypoVcmkf5MXnhYML9hHKneXBpu/VJa9mQ0 2NIweKUwCHZKRU5jx6/mfLEbRxmuyClIDsfmnlhNMLdBMHO+h0J8fFEqwFJ3NeJ6So0o 8kArW1OhquasL6igTwmFjpAUYa/rK7uXdBF7syw+BBbWjZSIv721FPmz39x3KY0ljlZ1 qzdxsamcZQjrYx2Lir31eS5oHefcME142BsOgz6Mckt+WUjkA2nrwHdK8KkmdVafqsgI ISfMBF5gKYSUTd5ifRNXb4kEn6NisG3p2Dyd+Btjn2Kdi559UWvwLfKSb72+K3yN54CI VSXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=RuVMi+yzQuqrWt1PfGiMDTX9P2hZ817ws+8wqAp5qk0=; b=MxsvKap6ADe6RyOyngL+rhlimT4W9Nj09oeZIheEribfj6/7rUHhDf34Z2ogvdAw0W 7A5CMzPCoNrRBYa4/ZzQxPMk+Qcw4SYuOiUs037zaSz9aFNMPi6s3fW6j3VjLNf1qxZ3 935oPrji7zMdROvXDm88Krj5jCx7UnVUlZ4K+2SgHNAOuIt0mverIGi6DPOsN2H6hNDQ 1iZ3sH/NU3e0HRDOc+T4TiIU+XN+JGTa1qrLfIeQtYUU2jq+MXdWcZOlb9rISl/jM1j5 5M5uifr8DDH0EWzAeDOZJz7e1S7Te7tzxYxoWMM14QOBeTCFLPC0CJBsEt6FC/ZSIHfe gfdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OFTc6ukA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si6019170otg.35.2020.03.29.18.07.01; Sun, 29 Mar 2020 18:07:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OFTc6ukA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbgC3BFh (ORCPT + 99 others); Sun, 29 Mar 2020 21:05:37 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:38388 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727549AbgC3BFh (ORCPT ); Sun, 29 Mar 2020 21:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585530337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RuVMi+yzQuqrWt1PfGiMDTX9P2hZ817ws+8wqAp5qk0=; b=OFTc6ukA9Eu7/YROBinqV8JEddEk1WV2Oz9uDpKOL0yj+KcrLuMnp6Ztxyt8ANy4QmN59z 7CdVlf1taT9k7BG31u8hIh3Dy3g23Cg8bv1wZyfGgzW3JsRwVVWbVND6FFM8BlYfL4CEsZ g6tjNA9PKTSNl0ACLavVPW/vdNqMJYw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-w4fOFj-WPMetl7R3dG9Hmw-1; Sun, 29 Mar 2020 21:05:35 -0400 X-MC-Unique: w4fOFj-WPMetl7R3dG9Hmw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 211B1189F77A; Mon, 30 Mar 2020 01:05:34 +0000 (UTC) Received: from elisabeth (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EED35C1BB; Mon, 30 Mar 2020 01:05:31 +0000 (UTC) Date: Mon, 30 Mar 2020 03:05:26 +0200 From: Stefano Brivio To: Simran Singhal Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add line after variable declarations Message-ID: <20200330030526.7a1a3b9d@elisabeth> In-Reply-To: <20200325164451.GA17569@simran-Inspiron-5558> References: <20200325164451.GA17569@simran-Inspiron-5558> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simran, On Wed, 25 Mar 2020 22:14:52 +0530 Simran Singhal wrote: > Add whiteline after variable declarations to remove the checkpatch.pl > warning: > WARNING: Missing a blank line after declarations > > Signed-off-by: Simran Singhal Sorry for the late review. This patch introduces similar changes to the other patches you posted to fix checkpatch warnings for rtl8723bs, so I think they should be posted as a patchset instead. -- Stefano