Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 10:46:33 +0200
From:   Oleg Nesterov <oleg@redhat.com>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc:     ebiederm@xmission.com, christian.brauner@ubuntu.com, tj@kernel.org,
        akpm@linux-foundation.org, guro@fb.com, joel@joelfernandes.org,
        linux-kernel@vger.kernel.org, Mingfangsen <mingfangsen@huawei.com>,
        linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in
 kill_something_info
Message-ID: <20200330084632.GA13298@redhat.com>
References: <80236965-f0b5-c888-95ff-855bdec75bb3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <80236965-f0b5-c888-95ff-855bdec75bb3@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/30, Zhiqiang Liu wrote:
>
> @@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
>  {
>  	int ret;
> 
> -	if (pid > 0) {
> -		rcu_read_lock();
> -		ret = kill_pid_info(sig, info, find_vpid(pid));
> -		rcu_read_unlock();
> -		return ret;
> -	}
> +	if (pid > 0)
> +		return kill_proc_info(sig, info, pid);
> 

Acked-by: Oleg Nesterov <oleg@redhat.com>