Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com>
 <20200320121657.1165-26-jinpu.wang@cloud.ionos.com> <619d2dda-3c4e-a909-ab78-1201057b542c@acm.org>
In-Reply-To: <619d2dda-3c4e-a909-ab78-1201057b542c@acm.org>
From:   Danil Kipnis <danil.kipnis@cloud.ionos.com>
Date:   Mon, 30 Mar 2020 12:17:45 +0200
Message-ID: <CAHg0HuyBtKRca=8k_O9ZvPREMry4L7pcmKsm=GUCq_w8Gtjd-g@mail.gmail.com>
Subject: Re: [PATCH v11 25/26] block/rnbd: a bit of documentation
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Jack Wang <jinpu.wang@cloud.ionos.com>,
        linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
        Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        Sagi Grimberg <sagi@grimberg.me>,
        Leon Romanovsky <leon@kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Roman Penyaev <rpenyaev@suse.de>,
        Pankaj Gupta <pankaj.gupta@cloud.ionos.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 28, 2020 at 8:40 PM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 2020-03-20 05:16, Jack Wang wrote:
> > +RNBD (RDMA Network Block Device) is a pair of kernel modules
> > +(client and server) that allow for remote access of a block device on
> > +the server over RTRS protocol using the RDMA (InfiniBand, RoCE, iWarp)
>                                                                    ^^^^^
> Isn't this protocol usually spelled as iWARP? See also
> https://en.wikipedia.org/wiki/IWARP.

Right.

> > +dev_search_path option can also contain %SESSNAME% in order to provide
> > +different deviec namespaces for different sessions.  See "device_path"
>              ^^^^^^
>              device?
Will fix the typo.

> > +option for details.


> Otherwise this patch looks fine to me. Hence:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Thank you.