Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2289598ybb; Mon, 30 Mar 2020 03:24:30 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuL8kLKbnX2mvRHLQP19oF8F/TokhHU2cthMz1DDS6ublsKLfbt1TGPINewZuZLcAGgyKKG X-Received: by 2002:aca:4b56:: with SMTP id y83mr7323938oia.142.1585563870589; Mon, 30 Mar 2020 03:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585563870; cv=none; d=google.com; s=arc-20160816; b=RmueIxLjlpP85F0M59U5CW8FZyws6kEPjuyJC78zfN4TFeOsH+KnuJaEHtB5LmQqHq 0XTfYXG27C4A3t1cM2rh4rx09HaMUh4nSVOcJguM2UWZHnUFhppl6St+Y/D0Jmn6/oHE +0zNQON4TcP6Lz+amFuu2PtFpNolVH3OrDFY/2YLFoQSSSCHUyNGDi8/xtHjnHZNTl4G Utpm8oFPpS5kHpC6d5kqkSLTPOJpH3r9OdZeFcil2yTsV79SLlyVNQPJfcVCgObjxRpR fJRIGAtO8gpwPxaD3EJNHfRty0oMVZYdznphNqfZJ1dOpHjOIf9s4i4fzf8AiCxe6KEx a9Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5FQ6G0+7lYJplFDoIGeU2D86AessDV4G97UWA401VBs=; b=FaZi1bn6rZVYOLSwTAYR0dJVRKHsB7x8+pLWvf8tGZsHRGTDoeYMxvtWG0KG+8KBZ0 TYUvwyP3d8Ln48m9LeubE/XZfC+o6zuvuPG2VOlm19lRVbW5iiBPDTWE0lS7/oigJT7o nNA18Be/GMR9mOxwPl+xDNRYrSkD4nsSVdUQDuHXFAwBrxu0A6UL8w0iAyHyP+z3G0Ce sMRwAyW1q7KSdYGXZehuAdH2iNf9x478kfGNubCYy6e/kUrTF74HAQCH7fw39dmd2Wtj Zh82QW/I5S2ApDhIK/Mh6lsFd1P9WWrbJ0dpU2RJwX+ZjcpH0LVaBeUmt9eTAhx5tsyf vkQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4si6331903otu.74.2020.03.30.03.24.17; Mon, 30 Mar 2020 03:24:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729241AbgC3KYA (ORCPT + 99 others); Mon, 30 Mar 2020 06:24:00 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12650 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729125AbgC3KYA (ORCPT ); Mon, 30 Mar 2020 06:24:00 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C4000249121698C47994; Mon, 30 Mar 2020 18:23:48 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Mon, 30 Mar 2020 18:23:46 +0800 From: Mao Wenan To: , , , , , , , , , , , , , CC: , , , Subject: [PATCH net] veth: xdp: use head instead of hard_start Date: Mon, 30 Mar 2020 18:26:31 +0800 Message-ID: <20200330102631.31286-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org xdp.data_hard_start is mapped to the first address of xdp_frame, but the pointer hard_start is the offset(sizeof(struct xdp_frame)) of xdp_frame, it should use head instead of hard_start to set xdp.data_hard_start. Otherwise, if BPF program calls helper_function such as bpf_xdp_adjust_head, it will be confused for xdp_frame_end. Signed-off-by: Mao Wenan --- drivers/net/veth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index d4cbb9e8c63f..5ea550884bf8 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -506,7 +506,7 @@ static struct sk_buff *veth_xdp_rcv_one(struct veth_rq *rq, struct xdp_buff xdp; u32 act; - xdp.data_hard_start = hard_start; + xdp.data_hard_start = head; xdp.data = frame->data; xdp.data_end = frame->data + frame->len; xdp.data_meta = frame->data - frame->metasize; -- 2.20.1