Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 12:46:04 +0100
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     Oscar Carter <oscar.carter@gmx.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between
 previous defines
Message-ID: <20200330114604.GA52025@jiffies>
References: <20200327165802.8445-1-oscar.carter@gmx.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200327165802.8445-1-oscar.carter@gmx.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jiffies (5.151.93.48) by LO2P265CA0342.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Mon, 30 Mar 2020 11:46:06 +0000
X-Originating-IP: [5.151.93.48]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe282265-44d6-445d-86db-08d7d49feec2
X-MS-TrafficTypeDiagnostic: DBBPR08MB4789:
X-Microsoft-Antispam-PRVS: <DBBPR08MB4789BFFA0F9A572C11F32B50B3CB0@DBBPR08MB4789.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-Forefront-PRVS: 0358535363
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4491.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(136003)(366004)(376002)(346002)(39830400003)(396003)(53546011)(33656002)(81166006)(9686003)(508600001)(6916009)(8676002)(55016002)(81156014)(33716001)(2906002)(86362001)(316002)(52116002)(66946007)(6496006)(54906003)(5660300002)(66476007)(8936002)(4326008)(186003)(1076003)(956004)(9576002)(16526019)(26005)(66556008)(44832011)(518174003);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T7293nycefwjs83W9fd0+ucNFCZ5xBbzwGhpBt8xvKzzfpJ407Pyh0JIcnXUo+0t3QMhJtYBKYYE+8y3cTYMBoFJ7jcghzkhpdZoVk1Zz/Qj4e+goFWO531DcKJRhhLxQSJgnvl8+GmpJrSYqOsCYaIUY7Xva7oFITKF21HsRuFNPDTr78HXZNc7hjHdrX8bXl0cAvxy7lOjzHgjvj7ochtFuscUe1UTwfE8aBQVeMFBveFGzvKDOQbXpFctEGnwUyTtw6XNBEKCHru6OYW3lrvoOItuYr1r1n1DFNvJtBaG4dK79nUdIiMRqpp2oGpEXUeKwf2Tyhpo3wTMnSgbzwRjLT0nTyLq5OviZevBsOSOQBzez1Lwqfy1yxL+J2Zra4aSgLzQg47ZAR3m8HfJN9Oe7byXiU3JBQl1sz9dEKGBHX8kgRsh40J5tuIDKyAltlH3BFuArIz1Ue+NRWOx7O+waX0V1WP7Kf9kDU1JT5URSlGNhUb3GGwa8hQkZa4V
X-MS-Exchange-AntiSpam-MessageData: zQJ6Z8rXJ2Lu/Drtc/iorheXtjMp1Oq8aSGaNaz0YZQEijpBIzgVx8zlOGtotyMShJUKy4MseLLKKh90iGnV4OgKVIjG9/ViC2R2OZUNRzkw0Z+UU54TlywfenIQyyH8YbJcj5C3ZrWs1VlnYig8og==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: fe282265-44d6-445d-86db-08d7d49feec2
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2020 11:46:06.8458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /qsR7SR+f7k0noula9GyUxbkUS5h5i77UmXXviu+BS7OrUghoGCwG/1IM3ypeZN9xmQ4R0pei1DfPykTJ/Itw++1ublywNnI9Zrl3UuPdRU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4789
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/27/20 17:58:02, Oscar Carter wrote:
> Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> defines instead of using the OR between two new BIT macros. Thus, the
> code is more clear.
> 
> Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/staging/vt6656/mac.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> index c532b27de37f..b01d9ee8677e 100644
> --- a/drivers/staging/vt6656/mac.h
> +++ b/drivers/staging/vt6656/mac.h
> @@ -177,7 +177,7 @@
>  #define EnCFG_BBType_a		0x00
>  #define EnCFG_BBType_b		BIT(0)
>  #define EnCFG_BBType_g		BIT(1)
> -#define EnCFG_BBType_MASK	(BIT(0) | BIT(1))
> +#define EnCFG_BBType_MASK	(EnCFG_BBType_b | EnCFG_BBType_g)
>  #define EnCFG_ProtectMd		BIT(5)
> 
>  /* Bits in the EnhanceCFG_1 register */
> --
> 2.20.1
> 

Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>

Thanks,
Quentin