Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Date:   Mon, 30 Mar 2020 17:55:18 +0530
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     madhuparnabhowmik10@gmail.com, hariprasad.kelam@gmail.com,
        colin.king@canonical.com, tony.olech@elandigitalsystems.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrianov@ispras.ru
Subject: Re: Possible data-race related bug in u132_hcd module.
Message-ID: <20200330122518.GA12077@madhuparna-HP-Notebook>
References: <20200330115243.11107-1-madhuparnabhowmik10@gmail.com>
 <20200330120207.GA2807@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200330120207.GA2807@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 30, 2020 at 02:02:07PM +0200, Greg KH wrote:
> On Mon, Mar 30, 2020 at 05:22:43PM +0530, madhuparnabhowmik10@gmail.com wrote:
> > Hi,
> > 
> > This bug is found by? Linux Driver Verification project (linuxtesting.org).
> > 
> > The bug is related to the parallel execution of u132_probe() function and?u132_hcd_exit() function in u132_hcd.c. In case the module is unloaded when the probe function is executing there can be data race as the mutex lock?u132_module_lock is not used properly.?
> 
> Please note that module unloading, while a nice thing to have, is never
> something that happens automatically :)
> 
> > i) Usage of mutex lock only when writing into the u132_exiting variable in?u132_hcd_exit(). The lock is not used when this variable is read in?u132_probe().
> > 
> > Moreover, this variable does not serve its?purpose, as even if locking?is used while the u132_exiting variable is read in probe(), the function may still miss that exit function is executing if it acquires the mutex before exit() function does.
> > 
> > How to fix this?
> > 
> > ii) Usage of mutex while adding entries in?u132_static_list in probe function but not in exit function while unregistering.
> > This should be easy to fix by holding the mutex in the exit function as well.
> > 
> > There can be other synchronization problems related to the usage of u132_module_lock in this module, I have only spotted these so far.
> > 
> > Please let me know if this bug report is helpful and I can send a patch fixing it.
> 
> Please just send a patch, no need to ever ask if you should, that's the
> best way to report and fix anything.
>
Sure, I will do it.

Thank you,
Madhuparna

> thanks,
> 
> greg k-h