Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2490927ybb; Mon, 30 Mar 2020 07:12:35 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2izisGwQcbt1aDunywT1Ar0Kn+Gw0kR1RAAOlxYZ0E3r6HmJktaXc5EHk6EzeOYBZQmEO X-Received: by 2002:a9d:1921:: with SMTP id j33mr9479508ota.309.1585577555651; Mon, 30 Mar 2020 07:12:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585577555; cv=none; d=google.com; s=arc-20160816; b=Dc3Bbxjm18uJpegGKZGHmbzeeG9rXZE1c1De3c5+yRuRxaNQigwAJPDVd4V+r59thz XoX6bQFQTsWZdaJ9xGCJh9tymEuTFNmOfSUtA9qpXPJXtG1qe9l8+Okxc0JC+t7PAIqP 1KuGPFLGK+3cT1rSQpkTKsdKk7UwocHjyvuyeRAVzTmmWmp0erV4bgMB22vFZ5kpxFN7 Xhn1r4+o7OsNj86aoOMRI5RfTm9iRyU7uN2HVJkS1yi7Qy1tt38OztC9bcCuVB/SK09c 6rWhJGSUGOqQu8gSk2M/DS2pQa5SmoeZXGxs+/NFQi5zX1ZP44BadyCVmqeSYHwfT06E Axhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=0lGR2DaAD+VNN8iiFuk8bnT+k7Mt5MvLdRPbVztPsfs=; b=F6oBQH9hshhdJ/IfEYAHjewoZfE4kP/PqUbK5z4/cTrnrW4CrSwbU8eo9OpdjU7p7Q ALudTh9dV3UlW02C6trb0iHh0gxYDRiHquICwHWRcQNsZfODRlfxBsNsFn1qQG/5iUUU geqxIrlsSfHHEbZ5TO6QIsKUpWRk7r3NVfmmuRT+0PsUw2R+iHAgdNDjGaDdjoqwaFYE 3wr2GUNkvTB8R5e0g5mvG0cSTg/UM0u9qVW5DSy/EAjE6RYBZTQ1aMscO8En0GVSSsGD ckqk5lAiPaVtXvXM/gSqashv4/gM/Y1jz7jCtzwk7N0mRkifa7ds7MIa842KPJtolGnb 3tfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r19si5861537otg.54.2020.03.30.07.12.09; Mon, 30 Mar 2020 07:12:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbgC3OLL (ORCPT + 99 others); Mon, 30 Mar 2020 10:11:11 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60904 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgC3OLL (ORCPT ); Mon, 30 Mar 2020 10:11:11 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id B5B8F29661E From: Enric Balletbo i Serra Subject: Re: [PATCH 1/2] platform/chrome: chromeos_laptop: make I2C API conversion complete To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Benson Leung , linux-kernel@vger.kernel.org References: <20200326210952.12857-1-wsa+renesas@sang-engineering.com> <20200326210952.12857-2-wsa+renesas@sang-engineering.com> Message-ID: <2d4269eb-0f17-47c8-d393-a3887a72526e@collabora.com> Date: Mon, 30 Mar 2020 16:11:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200326210952.12857-2-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 26/3/20 22:09, Wolfram Sang wrote: > When converting to i2c_new_scanned_device(), it was overlooked that a > conversion to i2c_new_client_device() was also needed. Fix it. > > Fixes: c82ebf1bf738 ("platform/chrome: chromeos_laptop: Convert to i2c_new_scanned_device") > Signed-off-by: Wolfram Sang > --- > drivers/platform/chrome/chromeos_laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c > index 4f3651fcd9fe..472a03daa869 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -103,7 +103,7 @@ chromes_laptop_instantiate_i2c_device(struct i2c_adapter *adapter, > pr_debug("%d-%02x is probed at %02x\n", > adapter->nr, info->addr, dummy->addr); > i2c_unregister_device(dummy); > - client = i2c_new_device(adapter, info); > + client = i2c_new_client_device(adapter, info); > } > } > > Queued for 5.7. Thanks. Enric