Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: l3JrtsUXSnzSRdg6MF1Bp1wGgCNNFVTet9jSc5fNfuvUmGYe5ZYKZciS83QDQlMFK6wCazi4x0
 kYU15aR2wtZw==
IronPort-SDR: 8x6LKW1BZpgkOpaBsEsSTOpNcDwxG0kfXVvoTJrEUwHjmjGfJnE2D4EZ4Y5/3vq5ZmX6L4A6mV
 +zYipkg/sfOw==
Date:   Mon, 30 Mar 2020 17:51:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Heiko Stuebner <heiko@sntech.de>
Cc:     gregkh@linuxfoundation.org, jslaby@suse.com,
        matwey.kornilov@gmail.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, lukas@wunner.de,
        christoph.muellner@theobroma-systems.com,
        giulio.benetti@micronovasrl.com
Subject: Re: [PATCH DON'T APPLY v2 3/7] serial: 8250: Support rs485 bus
 termination GPIO
Message-ID: <20200330145102.GU1922688@smile.fi.intel.com>
References: <20200325231422.1502366-1-heiko@sntech.de>
 <20200325231422.1502366-4-heiko@sntech.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200325231422.1502366-4-heiko@sntech.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 26, 2020 at 12:14:18AM +0100, Heiko Stuebner wrote:
> From: Lukas Wunner <lukas@wunner.de>
> 
> Amend the serial core to retrieve the rs485 bus termination GPIO from
> the device tree (or ACPI table) and amend the default ->rs485_config()
> callback for 8250 drivers to change the GPIO on request from user space.

> +	port->rs485_term_gpio = devm_gpiod_get(dev, "rs485-term",
> +					       GPIOD_FLAGS_BIT_DIR_OUT);
> +	if (IS_ERR(port->rs485_term_gpio)) {
> +		ret = PTR_ERR(port->rs485_term_gpio);
> +		port->rs485_term_gpio = NULL;
> +		if (ret != -ENOENT) {
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(dev, "Cannot get rs485-term-gpios\n");
> +			return ret;
> +		}

NIH of gpiod_get_optional().

> +	} else {
> +		ret = gpiod_get_value(port->rs485_term_gpio);
> +		if (ret < 0) {
> +			dev_err(dev, "Cannot get rs485-term-gpios value\n");
> +			return ret;
> +		}
> +		if (ret)
> +			rs485conf->flags |= SER_RS485_TERMINATE_BUS;
> +	}

-- 
With Best Regards,
Andy Shevchenko