Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 16:46:00 +0100
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     "John B. Wyatt IV" <jbwyatt4@gmail.com>
Cc:     outreachy-kernel@googlegroups.com,
        Julia Lawall <julia.lawall@inria.fr>,
        Stefano Brivio <sbrivio@redhat.com>,
        Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Ian King <colin.king@canonical.com>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vt6656: add error code handling to unused
 variable
Message-ID: <20200330154600.GA125210@jiffies>
References: <20200329084320.619503-1-jbwyatt4@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200329084320.619503-1-jbwyatt4@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jiffies (5.151.93.48) by LO2P265CA0169.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Mon, 30 Mar 2020 15:46:01 +0000
X-Originating-IP: [5.151.93.48]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b62de620-3a39-4dab-30bf-08d7d4c17304
X-MS-TrafficTypeDiagnostic: DBBPR08MB4538:
X-Microsoft-Antispam-PRVS: <DBBPR08MB45380A13D11558A36DDC2127B3CB0@DBBPR08MB4538.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:635;
X-Forefront-PRVS: 0358535363
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4491.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(366004)(346002)(376002)(39830400003)(396003)(136003)(8936002)(54906003)(7416002)(186003)(5660300002)(26005)(44832011)(16526019)(1076003)(6916009)(81166006)(81156014)(8676002)(9576002)(2906002)(33716001)(86362001)(9686003)(33656002)(55016002)(4326008)(53546011)(6496006)(52116002)(956004)(508600001)(316002)(66556008)(66946007)(66476007);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Zc8roQMny7lEroB5EWxip3TxWGPhlG/IjSXZltU60ZNa/54o21sTOvN178+ATx2L/a6qpuMgDsgl5Xc4NYQr2VGVXAXqa2s6xPwuJsPICl1dxKotXk/kiktNGvdCU+16kFayAvAl3VaGWu1h8yrdBIkSQxZ+Mjgu+GXOdx6FIRfFJhwnP1gV+J1Q3VESEnPX0I5H2sSkyxs1txQrOR3BJM92kIAhu3gHOP9ZseL3xRNoirYPf5DE3ZPi2+6KJjzAKnUmhs7YenhNanRDmbGaLpZAfkQS5zf8SlUnyshLxhnWnvviZvSC0oR+XH3TDfUtGdfrKC5M+Ma8OtV2H56YXb2BmUi95tIDphPkCodYNmXqefZSp1NICZzusoGwLlUILfxZ7I0gg/LMDsPpfXQvUlr9k1ibako1C0c9VPaNaiqYe3xh8u88Ce+xBmk/ZQzl
X-MS-Exchange-AntiSpam-MessageData: GwmWchUX2xaxZh8V0nuke0yR5lBHdeHKIrnSmlAH/bHMATJNgeAFMJ52vAeTL+y6l4P0CWYfjRpoTz51R8V5LxoCy6z21qn7Or1atWd8ecj0kNcx4MsLbfFhri4Y8QF9zgHd6ELUyAUafm78BVQ5IA==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: b62de620-3a39-4dab-30bf-08d7d4c17304
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2020 15:46:02.0705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G4LT4iK/OIgRo4hEC030dZUOQU3TpzZlCkknLjhGcaxkK5AA0wG3OTyivVTj7yOgsBIJqFe/JH6DrEzrHYxalOqsCm0O2dwna3WCi67kmg4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4538
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/29/20 01:43:20, John B. Wyatt IV wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
> 
> Issue reported by coccinelle (coccicheck).
> 
> Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> v3: Forgot to add v2 code changes to commit.
> 
> v2: Replace goto statements with return.
>     Remove last if check because it was unneeded.
>     Suggested-by: Julia Lawall <julia.lawall@inria.fr>

Because it's after the comment line (---), this Suggested-by tag will be
stripped-off when applying the patch.

> 
>  drivers/staging/vt6656/card.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index dc3ab10eb630..239012539e73 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv)
>  {
>  	int ret = 0;
>  
> -	vnt_exit_deep_sleep(priv);
> +	ret = vnt_exit_deep_sleep(priv);
> +	if (ret)
> +		return ret;
>  
> -	vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
> +	ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
> +	if (ret)
> +		return ret;
>  
>  	switch (priv->rf_type) {
>  	case RF_AL2230:
> @@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv)
>  	case RF_VT3226:
>  	case RF_VT3226D0:
>  	case RF_VT3342A0:
> -		vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
> -				    (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
> +		ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
> +					 (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
>  		break;
>  	}
> +	if (ret)
> +		return ret;
>  
> -	vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
> -
> -	return ret;
> +	return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
>  }
>  
>  void vnt_set_bss_mode(struct vnt_private *priv)
> -- 
> 2.25.1
> 

If you could fix it, then add my review tag.

Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>

Thanks,
Quentin