Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 16:54:19 +0100
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     Oscar Carter <oscar.carter@gmx.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        Amir Mahdi Ghorbanian <indigoomega021@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use defines in preamble_type variables
Message-ID: <20200330155419.GA133370@jiffies>
References: <20200328140955.23615-1-oscar.carter@gmx.com>
 <20200330154902.GB125210@jiffies>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200330154902.GB125210@jiffies>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jiffies (5.151.93.48) by LO2P265CA0432.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Mon, 30 Mar 2020 15:54:20 +0000
X-Originating-IP: [5.151.93.48]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5531c284-d347-4327-a478-08d7d4c29c8f
X-MS-TrafficTypeDiagnostic: DBBPR08MB4315:
X-Microsoft-Antispam-PRVS: <DBBPR08MB43153FE4C22C24D3E0952263B3CB0@DBBPR08MB4315.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-Forefront-PRVS: 0358535363
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4491.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(376002)(136003)(346002)(396003)(39830400003)(366004)(26005)(4326008)(52116002)(6496006)(44832011)(1076003)(81166006)(66946007)(8676002)(81156014)(33716001)(66476007)(33656002)(55016002)(8936002)(9576002)(9686003)(86362001)(53546011)(6916009)(316002)(2906002)(186003)(16526019)(508600001)(956004)(66556008)(5660300002)(54906003)(518174003);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: x4ACSTS6YRaGGOot0kjCPwrU0XRdzATR6K5oEJa2uHqQQoesXZtsN6B/ZORdrqK5qjtuSvkxb5eSepUAYQu0BCN2l6Lnh/4r4Es5/bDsIriFQB2fublYJQ7TmNzV2Mk3Aoom0jwnV6HDPSHHQav1r9o9PQNGRJFHa9FIANuMmO3750C8pDq/7lcj93kNEryoayLg8cqFIoBQWXGgnkLVUTtdiv+I0sgDDHCvHUBXDwW4A+dyC9pqkAnlv8ZzfwOaInm8h+4xoAzc5sdeOOl2GFctW1Fg06RM+9f6axRV5IlXxlRMRqtzGEDHTTQstUI0Ucm4FnNQwBJbMcbdXw35gJhsgSEHXPMypt2HrIp8aFDgFXCytl3/N25iKv+SWXrcK03YJWaAxKH92EV9RTovVWHUkv3lW9y/RPpH2XsiTUqgHzRNYpIkJNK8+8A1h/4BlH3VVbXS0zC0tnQuo5z3Va4ByJf3UTYmyCJWPbpb+dqGeF80vSRdSNhi/l7KtiHe
X-MS-Exchange-AntiSpam-MessageData: Ce4lad+lauqHVJV2QAWn6m10iBInbkwKAiBN6QXhoqe5PpR4ECEjT8w6Vj4Wi6S9y8FXvg+p3HhotPryPlYBN/lnJautXRf39JzVoDkuh4JJh8qOnf/oml1ytaElOyr2ysTv3+XEBvcZ4cC5VgIdyg==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: 5531c284-d347-4327-a478-08d7d4c29c8f
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2020 15:54:21.2437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ssB5AcV8JZYLi0Krqo/GJA6XFv50+zBJb9WQh1d/xEJcU1pnwYkiEQPapha9LJn0A/8tzjLVTWtksBTJmQLycCq+dC8Kun7yIshY5fhSTdg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4315
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/30/20 16:49:04, Quentin Deslandes wrote:
> On 03/28/20 15:09:55, Oscar Carter wrote:
> > Use the PREAMBLE_SHORT and PREAMBLE_LONG defines present in the file
> > "baseband.h" to assign values to preamble_type variables. Also, use the
> > same defines to make comparisons against this variables.
> > 
> > In this way, avoid the use of numerical literals or boolean values and
> > make the code more clear.
> > 
> > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> > ---
> >  drivers/staging/vt6656/baseband.c | 8 ++++----
> >  drivers/staging/vt6656/main_usb.c | 6 +++---
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> > index a19a563d8bcc..9bbafa7fff61 100644
> > --- a/drivers/staging/vt6656/baseband.c
> > +++ b/drivers/staging/vt6656/baseband.c
> > @@ -142,7 +142,7 @@ unsigned int vnt_get_frame_time(u8 preamble_type, u8 pkt_type,
> >  	rate = (unsigned int)vnt_frame_time[tx_rate];
> > 
> >  	if (tx_rate <= 3) {
> > -		if (preamble_type == 1)
> > +		if (preamble_type == PREAMBLE_SHORT)
> >  			preamble = 96;
> >  		else
> >  			preamble = 192;
> > @@ -198,7 +198,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
> >  	case RATE_2M:
> >  		count = bit_count / 2;
> > 
> > -		if (preamble_type == 1)
> > +		if (preamble_type == PREAMBLE_SHORT)
> >  			phy->signal = 0x09;
> >  		else
> >  			phy->signal = 0x01;
> > @@ -207,7 +207,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
> >  	case RATE_5M:
> >  		count = DIV_ROUND_UP(bit_count * 10, 55);
> > 
> > -		if (preamble_type == 1)
> > +		if (preamble_type == PREAMBLE_SHORT)
> >  			phy->signal = 0x0a;
> >  		else
> >  			phy->signal = 0x02;
> > @@ -224,7 +224,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
> >  				ext_bit = true;
> >  		}
> > 
> > -		if (preamble_type == 1)
> > +		if (preamble_type == PREAMBLE_SHORT)
> >  			phy->signal = 0x0b;
> >  		else
> >  			phy->signal = 0x03;
> > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> > index 8e7269c87ea9..dd89f98cc18c 100644
> > --- a/drivers/staging/vt6656/main_usb.c
> > +++ b/drivers/staging/vt6656/main_usb.c
> > @@ -99,7 +99,7 @@ static void vnt_set_options(struct vnt_private *priv)
> >  	priv->op_mode = NL80211_IFTYPE_UNSPECIFIED;
> >  	priv->bb_type = BBP_TYPE_DEF;
> >  	priv->packet_type = priv->bb_type;
> > -	priv->preamble_type = 0;
> > +	priv->preamble_type = PREAMBLE_LONG;
> >  	priv->exist_sw_net_addr = false;
> >  }
> > 
> > @@ -721,10 +721,10 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
> >  	if (changed & BSS_CHANGED_ERP_PREAMBLE) {
> >  		if (conf->use_short_preamble) {
> >  			vnt_mac_enable_barker_preamble_mode(priv);
> > -			priv->preamble_type = true;
> > +			priv->preamble_type = PREAMBLE_SHORT;
> >  		} else {
> >  			vnt_mac_disable_barker_preamble_mode(priv);
> > -			priv->preamble_type = false;
> > +			priv->preamble_type = PREAMBLE_LONG;
> >  		}
> >  	}
> > 
> > --
> > 2.20.1
> > 
> 
> Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> 
> Thank,
> Quentin

Disregard this review, a v2 has been sent.

Thanks,
Quentin