Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <DB7PR08MB3801F9765B4D16612BA0974B9CCB0@DB7PR08MB3801.eurprd08.prod.outlook.com>
In-Reply-To: <DB7PR08MB3801F9765B4D16612BA0974B9CCB0@DB7PR08MB3801.eurprd08.prod.outlook.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Mon, 30 Mar 2020 17:24:14 +0100
Message-ID: <CA+V-a8vYbUi3pypZ_TyjJ8VgFGQiXFMYP_iq-ZOvRv_B0xzLfg@mail.gmail.com>
Subject: Re: drivers/media/platform/davinci/vpfe_capture.c:883:20: warning:
 Redundant assignment
To:     David Binderman <dcb314@hotmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

On Mon, Mar 30, 2020 at 4:53 PM David Binderman <dcb314@hotmail.com> wrote:
>
> Hello there,
>
> linux-5.6/drivers/media/platform/davinci/vpfe_capture.c:883:20: warning: Redundant assignment of 'fmt->pixelformat' to itself. [selfAssignment]
>
> Source code is
>
>        fmt->pixelformat = fmt->pixelformat;
>
>
> Suggest code rework.
>
Fix for this is already in upstream with commit-id
5dbef6b3e09ffabf3b74d8d0fb230179d8fdc840
("media: davinci: fix incorrect pix_fmt assignment")

Cheers,
--Prabhakar

> Regards
>
> David Binderman