Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2648596ybb; Mon, 30 Mar 2020 10:09:33 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtiwyC00yT7VMvzbHxTJc+0mAJKiU2FxdsfJFMS8Z/DR5K2RzyYE3P23SG0OBDyduyvBeHN X-Received: by 2002:a9d:7452:: with SMTP id p18mr5255326otk.122.1585588172804; Mon, 30 Mar 2020 10:09:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585588172; cv=none; d=google.com; s=arc-20160816; b=m4KDMSLjAWmwLZUgei1oqkPxGnBeaBH/1jH1hMSdQZSoP+fUqTyNAnPVr1vEV3VX0V P6sUyqm15xDBDzBuPwGdAnWUXSMoxmEleWkvkyUgl0EuHzgCj7Ham33F8b6YzEorPhb8 7UVfUPhAOJqufm14rEbE9G/N4kb6wp7Ifo4HWq9YD7YvrQP/fZtesqviLg2i8My8JIKM L0EF8/A+CUr/OQoKFCinhNT5r13X6er0OzK7s7LNpH01DUjQlWFsP9KrQr1rfmPkMQ24 ZBq5TRMNyDBEWIhNh1Xq4//5SP524QtrRlUL0UZ+pJxa6grxRn427NFMvZ27jucuMvRa FAsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :user-agent:mime-version:in-reply-to:references:cc:to:subject:from :date; bh=Tta7JpHzntDgK3xyfN007ezwIudbnqoMBc2CTf/0ayg=; b=gfjamh0uOtmNrd5GaYLS2umspB99Smr3ns4uUrW7WFZE+PNkgqFB6bSmDbREDWZ+DP BqkhA5dI5n8sddEuDzWOWyGDaurvg3Z8r6bysqxSbCTHWPIx4hhYA31jMBIlLvyOhO3u /q8tbDNMs9o08Q7yswE4q8dE5vC3gvipakobhM+1sgn7f1RPB5S1lXxqDo2PPTEdTrM6 tK4iwqlR06w5tPkFc0kPClr7OTaGL9DvnXUq0a/tVAgiynmtqjd+3KKCuiX7xOWbAR4R CrWPFyfsBryXJCZ9zgifqhJA8dUinXOUaln1AdRGnKN1OvDu6x94buLAN38tTSw3j9yc r4rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m19si3848077otn.256.2020.03.30.10.09.16; Mon, 30 Mar 2020 10:09:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730099AbgC3RHE convert rfc822-to-8bit (ORCPT + 99 others); Mon, 30 Mar 2020 13:07:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:8908 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728739AbgC3RHE (ORCPT ); Mon, 30 Mar 2020 13:07:04 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02UH3CDc113154 for ; Mon, 30 Mar 2020 13:07:03 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 3022qg9u1j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2020 13:07:03 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Mar 2020 18:06:52 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 30 Mar 2020 18:06:49 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02UH6vND62390434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Mar 2020 17:06:57 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1B9AAE053; Mon, 30 Mar 2020 17:06:57 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55450AE045; Mon, 30 Mar 2020 17:06:57 +0000 (GMT) Received: from localhost (unknown [9.85.126.25]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 30 Mar 2020 17:06:57 +0000 (GMT) Date: Mon, 30 Mar 2020 22:36:54 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH 06/12] powerpc/32s: Make local symbols non visible in hash_low. To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/v0.15-13-gb675b421 (https://github.com/astroidmail/astroid) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 20033017-0008-0000-0000-000003674014 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20033017-0009-0000-0000-00004A88C152 Message-Id: <1585587984.mmaeo0dvju.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-03-30_07:2020-03-30,2020-03-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=818 mlxscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003300153 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy wrote: > In hash_low.S, a lot of named local symbols are used instead of > numbers to ease code lisibility. However, they don't need to be ^^^^^^^^^^ Nit.. visibility - Naveen