Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2683247ybb; Mon, 30 Mar 2020 10:50:26 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2eachxCrSycm5feul3XjIjc2khC7eDLmopJl7NXu3/o0JVYJbuOUDnFqUGwxt92SBippq X-Received: by 2002:aca:4cd8:: with SMTP id z207mr320665oia.155.1585590626110; Mon, 30 Mar 2020 10:50:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585590626; cv=none; d=google.com; s=arc-20160816; b=Vz2H2ZmTb0I/nyV/AxZYp/yHz+pUhgaV73Ni2ReuBvLAtlob7EQ9y7FSY62OXikd2N zMx5/daEcwjyLjjiy8NKpc1NbX5l6DHBF9R5B+pumsn3Oofz5uzMc0kDrXpIK8SW2E9u 6a8JGwFvUquGDUjkjyt4fq59yRdBEY0K3nQRpYy8nIT/zCWexXGgmj9toyualHoEWAZx 3/BcfB3i4Tzg/eW//J9iMJAgCILbao8pkLXqNdjsoSt+5K/8fwYVJMVPRbfGGSeaJ8qj iUoXgQEwAXTSEBm4qR0I4Ymrsv5mtDV92ukjlrTZSk1k5FQ6RRAKyzZ7nF2G5J0goXvi dARg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :user-agent:mime-version:in-reply-to:references:cc:to:subject:from :date; bh=oAz0EwjScfwDdC/C69tKCrSn9WTie/gloMY3oTm4eo0=; b=MylXgVArZnEkZC6T7ohMBHHyP0LajrQcH+ihWHnSV/zBPeBPt4qdW9gn0UIaQrVodv XrF1KwFfiy0SdEd4AVtBRfbLbO1lUsopq0y1NCEFxRwpSHfHFp9v7d0QuyYV3VRQsVQU Ep8VM5WH/sy14sB9LrqHgOGPOGarlP1QNdKu8yCJmr3QEvS0H4EvFsB0XG1+ZTbX5neQ puCPhtZDBjtmreDjHSBESNnsW1S9YiZLyS56Inw7cCu3k3xDxKKBKtyeHL+pCkxxXvUH hYUeICe4EdNvKEdOruh6h3xHLz3rv6/abpO+w+aB56NPxMq0gvDzu4wqPUsf+zAXlJJQ FFMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j25si5847263oii.86.2020.03.30.10.50.12; Mon, 30 Mar 2020 10:50:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729685AbgC3Rtx convert rfc822-to-8bit (ORCPT + 99 others); Mon, 30 Mar 2020 13:49:53 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58158 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgC3Rtx (ORCPT ); Mon, 30 Mar 2020 13:49:53 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02UHXZET098875 for ; Mon, 30 Mar 2020 13:49:52 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 3022nmj739-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2020 13:49:51 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Mar 2020 18:49:37 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 30 Mar 2020 18:49:34 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02UHnifJ52690966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Mar 2020 17:49:44 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB8F8A404D; Mon, 30 Mar 2020 17:49:44 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 252E0A4055; Mon, 30 Mar 2020 17:49:44 +0000 (GMT) Received: from localhost (unknown [9.85.126.25]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 30 Mar 2020 17:49:43 +0000 (GMT) Date: Mon, 30 Mar 2020 23:19:41 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH 06/12] powerpc/32s: Make local symbols non visible in hash_low. To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <1585587984.mmaeo0dvju.naveen@linux.ibm.com> <6bb184ed-b42f-f334-9445-e4fde107e8c9@c-s.fr> In-Reply-To: <6bb184ed-b42f-f334-9445-e4fde107e8c9@c-s.fr> MIME-Version: 1.0 User-Agent: astroid/v0.15-13-gb675b421 (https://github.com/astroidmail/astroid) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 20033017-0016-0000-0000-000002FB1E1A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20033017-0017-0000-0000-0000335ED924 Message-Id: <1585590551.xcqq0ccw21.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-03-30_07:2020-03-30,2020-03-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=833 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003300154 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy wrote: > > > Le 30/03/2020 à 19:06, Naveen N. Rao a écrit : >> Christophe Leroy wrote: >>> In hash_low.S, a lot of named local symbols are used instead of >>> numbers to ease code lisibility. However, they don't need to be >>                ^^^^^^^^^^ >> Nit..                  visibility > > > Lol, no. > > I mean't "lisibilité" in French, which means "readability" Touche :D - Naveen