Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2697643ybb; Mon, 30 Mar 2020 11:07:26 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtrt773y3OlodU0WNZuWbx1DExFAukS/aUKi/+l4DHoIeZHeZs0DalLiIxUzh2so2QsiZ84 X-Received: by 2002:aca:dd55:: with SMTP id u82mr418342oig.27.1585591646752; Mon, 30 Mar 2020 11:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585591646; cv=none; d=google.com; s=arc-20160816; b=valC/CmACoA4AQ4H0ZtmIo1dU7Xvo5TE0XthMQA+uyVSWtSkbq/uNz3Tx3iEJshcJF E9MzYijAMkZ6+UMmGU2p+Yx2s/rkbFWfdE6uDnkXWPgdOej2R+pglHvSE7GH0J7uFlxC PtGi3AgyosCYS0Yc+pAklxw/rUZqESfIe1Ln4BH7oEL8gU4WXeeZ0SCPJlLxIsKDPinB 2eTDG+Oxzbw7nzEvxmaZqeTMB1XtmhSBdiJckWQyeSwSGp7w2SevDTj+XSMPGIYxgUD1 8uqtw6V71Rch4ce7DMPH8JWVk199gxYesG+2j/hR6cSO1nsCY/R2xWEyNzYfn+sSGuf+ 90eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EIazmoWr1nLxxc8KNs37fnm42F/lDdp4/gYm3JHLHek=; b=oFowTxhzywy6keplfe5oIA/iLCLW1cqbVtRkUViVsXvhVnDtjKP/QbhkekBoLY6pRO OCOSyBHPWBLpZVmzOeG43e2amG6/JeIzWs0yMSvp42JZ8oZdJaVMcVFwOxQ4MLmmObjJ f6vObNva41CDIXq+zQvKYfWzNYBRCyTiIPiOWjRH2REho7NOc0O0+LKjcaJXUW2EN1pu RlGl1eIPMfHm+Sajk3ALaazrMMbwJynWaH9UA0hfyUbqxUaUC/vb2DVs94oDaKpXVyWr N/pE0RzWQF/XqRPY+YvWdS+RXNQjkPFnsjbmuE9Y4YqNcOD8C5we66Go8ZO9h01zpu0h uR/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IoKCdJlI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7si6781610oth.222.2020.03.30.11.07.13; Mon, 30 Mar 2020 11:07:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IoKCdJlI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729335AbgC3Rki (ORCPT + 99 others); Mon, 30 Mar 2020 13:40:38 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38785 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbgC3Rki (ORCPT ); Mon, 30 Mar 2020 13:40:38 -0400 Received: by mail-pg1-f196.google.com with SMTP id x7so9000558pgh.5 for ; Mon, 30 Mar 2020 10:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EIazmoWr1nLxxc8KNs37fnm42F/lDdp4/gYm3JHLHek=; b=IoKCdJlIr8dKSUui+FFl2O8BLgUnbJF6UcpsVTBUCUIxnVlSObs8uqbpJtVfo85MHD NSMiSHyRzun2Qw2uFSqKhacVvS9T1di6LetUQD1cCrF9rPt/SGxOjvQEku1cIwKpUsK4 Nyhahu2qk/o5MwyQBOY1XNgL+3twDOfx4D+Ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EIazmoWr1nLxxc8KNs37fnm42F/lDdp4/gYm3JHLHek=; b=lswpIs17xPJDLmg2RcDf7mW0H08nPgMpIEj4nEhAPSIlrPL5tcGADBPEJYLSIAYw4g 4AIH2+iyszt6n0tq35w+1Wi+J5L2/5+f9VBJn00uRSB1ndpkju56oDk7X6OzfDPkizVA 0swu9T5W55RGNb11qBmOIbRWdWkVSCJc6mMiAhCNDXlZcrmmzgZMSjk0KDVfhDE3PPNt RbZVf8Wtqu/HcrbQlzb5KA3HBtK+pCY9OB6b213+e/NnXmzdQGo/57DqM5/5JBi9yhBt SrsW9U5NHXk5g6zIC03818w0cxtE2CD0jzscVH4s/4JaePQr73zROrKmT3xJ3OE2XFdh evDQ== X-Gm-Message-State: ANhLgQ07Oxyu/EYnXVQuZqfvhunGlZ00Cml2LPN8juFYzSbNolYVCHEP FBycct26V5g3EYyJZ5DC1J0W8Q== X-Received: by 2002:a63:cf:: with SMTP id 198mr14239682pga.447.1585590035454; Mon, 30 Mar 2020 10:40:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i2sm10410628pfr.203.2020.03.30.10.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 10:40:34 -0700 (PDT) Date: Mon, 30 Mar 2020 10:40:33 -0700 From: Kees Cook To: Vlastimil Babka Cc: Luis Chamberlain , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <202003301040.E3099A957@keescook> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2020 at 06:23:57PM +0200, Vlastimil Babka wrote: > Boo, all the error prints should terminate with \n > Will wait for feedback before resend. eek, yes, good catch. :) -- Kees Cook