Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 13:14:59 -0700
From:   Matthew Wilcox <willy@infradead.org>
To:     Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc:     Kees Cook <keescook@chromium.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Jann Horn <jannh@google.com>, Jonathan Corbet <corbet@lwn.net>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Andrei Vagin <avagin@gmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Yuyang Du <duyuyang@gmail.com>,
        David Hildenbrand <david@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        David Howells <dhowells@redhat.com>,
        James Morris <jamorris@linux.microsoft.com>,
        Shakeel Butt <shakeelb@google.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Christian Kellner <christian@kellner.me>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Aleksa Sarai <cyphar@cyphar.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v6 00/16] Infrastructure to allow fixing exec deadlocks
Message-ID: <20200330201459.GF22483@bombadil.infradead.org>
References: <AM6PR03MB5170B2F5BE24A28980D05780E4F50@AM6PR03MB5170.eurprd03.prod.outlook.com>
 <871rpg8o7v.fsf@x220.int.ebiederm.org>
 <AM6PR03MB5170938306F22C3CF61CC573E4CD0@AM6PR03MB5170.eurprd03.prod.outlook.com>
 <202003282041.A2639091@keescook>
 <AM6PR03MB5170E0E722ED0B05B149C135E4CB0@AM6PR03MB5170.eurprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM6PR03MB5170E0E722ED0B05B149C135E4CB0@AM6PR03MB5170.eurprd03.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 30, 2020 at 10:12:02PM +0200, Bernd Edlinger wrote:
> On 3/29/20 5:44 AM, Kees Cook wrote:
> > On Sat, Mar 28, 2020 at 11:32:35PM +0100, Bernd Edlinger wrote:
> >> Oh, do I understand you right, that I can add a From: in the
> >> *body* of the mail, and then the From: in the MIME header part
> >> which I cannot change is ignored, so I can make you the author?
> > 
> > Correct. (If you use "git send-email" it'll do this automatically.)
> > 
> > e.g., trimmed from my workflow:
> > 
> > git format-patch -n --to "$to" --cover-letter -o outgoing/ \
> > 	--subject-prefix "PATCH v$version" "$SHA"
> > edit outgoing/0000-*
> > git send-email --transfer-encoding=8bit --8bit-encoding=UTF-8 \
> > 	--from="$ME" --to="$to" --cc="$ME" --cc="...more..." outgoing/*
> > 
> > 
> 
> Okay, thanks, I see that is very helpful information for me, and in
> this case I had also fixed a small bug in one of Eric's patches, which
> was initially overlooked (aquiring mutexes in wrong order,
> releasing an unlocked mutex in some error paths).
> I am completely unexperienced, and something that complex was not
> expected to happen :-) so this is just to make sure I can handle it
> correctly if something like this happens again.
> 
> In the case of PATCH v6 05/16 I removed the Reviewd-by: Bernd Edlinger
> since it is now somehow two authors and reviewing own code is obviously
> not ok, instead I added a Signed-off-by: Bernd Edlinger (and posted the
> whole series on Eric's behalf (after asking Eric's permissing per off-list
> e-mail, which probably ended in his spam folder)
> 
> Is this having two Signed-off-by: for mutliple authors the
> correct way to handle a shared authorship?

If the patch comes through you, then Reviewed-by: is inappropriate.
Instead, you should use Signed-off-by: in the second sense of
Documentation/process/submitting-patches.rst

This also documents how to handle "minor changes" that you make.