Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2960858ybb; Mon, 30 Mar 2020 17:04:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vso1lSxISqiIG0ce8Kn/Ik5bAckcaEzlZ+1xSkEEDszQUOVSR4RzdmeSYAuhAUG19B08u+N X-Received: by 2002:aca:5354:: with SMTP id h81mr420213oib.164.1585613096724; Mon, 30 Mar 2020 17:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585613096; cv=none; d=google.com; s=arc-20160816; b=WkidWMSI96/NKCXMuumJcq24tsao7i16IhQ0Wnvaat7r+jl90lpaZy2ItYP0j/qMHQ scXP5EhmVftC64PVy3WVXz0bu0I/HvDzsE3d1P+Uil0RGKffcGDtJcndAM5nPsW9ZpEI 1VsYjnuFuNn/ZHqMak+0dIYEnND3teZ0g2jFuRjPz3R8GVL5PJkXGPRCac4ih2PcSjQj L1NE4AurADW69/p6zlPg9t74gE2TiiIm6+A5llByk27SGs8fPtP38veSPLSzXCNXCsGg 10aAAyC/1A22oGR8plsp2u97Y8nbZMb/TCHPCmLWx6vjFS4eeN4ORafNSwLbqgolLfRs xnkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=XWMGIyM+EQlmNpNdyc1krEzJQU9C++X/ouqCdGDz9GY=; b=NEptnBl9LaHdTNJySiB8ZapbUXhMp0fsxI3TuW1TpazCxSXpxHYkH1SVOqcwAN12Mm Qi13yfVdSXW9xnNjjj4W7N1enqCBFcifWqngw8ESZvAkVj4ZMQkeRtAifktStgArI0h7 alanetCBQo1VpMIFAzcN3fvtOp3F46J/fTLOHbxkLPLtXxqXFAxf35gUc7q8fKveSOOz pX61uQtKnqiWkz3wY1P87P/yRAPWJM9r40/d/Oavud92EdFQTHuMit7n2F+o/4KTQQat dMToLtqPqya5C31TIXTSuvncQ0xj6msXVdIjqd8FEz8m02OPXxQZEZ0GaTy0amIcQ/SX imnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XOXEiEAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y25si8641196otj.304.2020.03.30.17.04.43; Mon, 30 Mar 2020 17:04:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XOXEiEAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729424AbgCaABW (ORCPT + 99 others); Mon, 30 Mar 2020 20:01:22 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:43833 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729398AbgCaABV (ORCPT ); Mon, 30 Mar 2020 20:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585612880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWMGIyM+EQlmNpNdyc1krEzJQU9C++X/ouqCdGDz9GY=; b=XOXEiEAaKLL/qWGDodJinds4T46g/a6BWON8Cvzvzytci53i2ANmGaFSRk0bFGAEA+2Soc oPx8rq0/KVVmu7drtENOaWuAgOD0dlYnIdI7FwtYos3tnR8OmfySmLHX/oPL3bEntZGFg1 TfJrAHHY5qX0UcjKWxn+H1pj/PoELGE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-9ovAUwVxO5em1mdQuZEQdA-1; Mon, 30 Mar 2020 20:01:16 -0400 X-MC-Unique: 9ovAUwVxO5em1mdQuZEQdA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E4B41800D50; Tue, 31 Mar 2020 00:01:14 +0000 (UTC) Received: from elisabeth (unknown [10.36.110.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D362100EBB6; Tue, 31 Mar 2020 00:01:09 +0000 (UTC) Date: Tue, 31 Mar 2020 02:01:03 +0200 From: Stefano Brivio To: "John B. Wyatt IV" Cc: outreachy-kernel@googlegroups.com, Julia Lawall , Forest Bond , Greg Kroah-Hartman , Quentin Deslandes , Colin Ian King , Malcolm Priestley , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8] staging: vt6656: add error code handling to unused variable Message-ID: <20200331020103.13008f53@elisabeth> In-Reply-To: <20200330233900.36938-1-jbwyatt4@gmail.com> References: <20200330233900.36938-1-jbwyatt4@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2020 16:39:00 -0700 "John B. Wyatt IV" wrote: > Add error code handling to unused 'ret' variable that was never used. > Return an error code from functions called within vnt_radio_power_on. > > Issue reported by coccinelle (coccicheck). > > Suggested-by: Quentin Deslandes > Suggested-by: Stefano Brivio > Reviewed-by: Quentin Deslandes ^ This should be dropped unless Quentin agrees to this version as well > Signed-off-by: John B. Wyatt IV Reviewed-by: Stefano Brivio -- Stefano