Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Mar 2020 11:34:36 +0800
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     "maobibo" <maobibo@loongson.cn>
Cc:     "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Huacai Chen" <chenhc@lemote.com>,
        "linux-mips" <linux-mips@vger.kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Message-ID: <1712ea7ba9a.dad1f80a33831.4741900511750683483@flygoat.com>
In-Reply-To: <778df899-4dc4-c2be-5b7b-79c16223b0fb@loongson.cn>
References: <1585557531-18849-1-git-send-email-maobibo@loongson.cn>
 <53CC90A0-3926-4642-91D4-F4F265F6AE90@flygoat.com> <778df899-4dc4-c2be-5b7b-79c16223b0fb@loongson.cn>
Subject: Re: [PATCH 02/39] MIPS: loongson64: Add header files path prefix
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: ZohoCN Mail
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--
Jiaxun Yang

 ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=80, 2020-03-30 18:00:19 maobibo <m=
aobibo@loongson.cn> =E6=92=B0=E5=86=99 ----
 >=20
 >=20
 > On 03/30/2020 04:55 PM, Jiaxun Yang wrote:
 > >=20
 > >=20
 > > =E4=BA=8E 2020=E5=B9=B43=E6=9C=8830=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=
=884:38:51, bibo mao <maobibo@loongson.cn> =E5=86=99=E5=88=B0:
 > >> Remove header files from arch/mips/include/asm/mach-loongson64
 > >> to arch/mips/loongson64/include/mach
 > >>
 > >> Signed-off-by: bibo mao <maobibo@loongson.cn>
 > >=20
 > > Hi Bibo,
 > >=20
 > > Thanks for your patch.
 > >=20
 > > What's your intention?
 > > Did you meet any problem about headers?
 > >=20
 >=20
 > Hi Jiaxun,
 >=20
 > When I add irqchip support for mips kvm, file virt/kvm/irqchip.c
 > requires local header file arch/mips/kvm/irq.h, it fails to compile.
 > Since there is file with the same name located at:
 >   arch/mips/include/asm/mach-generic/irq.h
 >   arch/mips/include/asm/mach-loongson64/irq.h
 >=20
 > The compiler fails to choose the correct header file irq.h,

You'd better rename kvm's irq.h in this case.

 >=20
 > regards
 > bibo,mao
 >=20
 > >> ---
 > >> arch/mips/Kconfig                                                 | 1=
 +
 > >> arch/mips/loongson64/Platform                                     | 2
 > >> +-
 > >> arch/mips/loongson64/env.c                                        | 8
 > >> ++++----