Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Mar 2020 09:29:52 +0100
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     Stefano Brivio <sbrivio@redhat.com>
Cc:     "John B. Wyatt IV" <jbwyatt4@gmail.com>,
        outreachy-kernel@googlegroups.com,
        Julia Lawall <julia.lawall@inria.fr>,
        Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Ian King <colin.king@canonical.com>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] staging: vt6656: add error code handling to unused
 variable
Message-ID: <20200331082952.GA13403@jiffies>
References: <20200330233900.36938-1-jbwyatt4@gmail.com>
 <20200331020103.13008f53@elisabeth>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200331020103.13008f53@elisabeth>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jiffies (5.151.93.48) by CWLP265CA0336.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:57::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Tue, 31 Mar 2020 08:29:53 +0000
X-Originating-IP: [5.151.93.48]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97a1b709-e73c-42eb-c306-08d7d54db049
X-MS-TrafficTypeDiagnostic: DBBPR08MB4474:
X-Microsoft-Antispam-PRVS: <DBBPR08MB4474B9C00C66C945F22212A9B3C80@DBBPR08MB4474.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-Forefront-PRVS: 0359162B6D
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4491.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(346002)(366004)(136003)(376002)(39830400003)(396003)(186003)(5660300002)(8676002)(1076003)(9686003)(9576002)(81166006)(4744005)(52116002)(86362001)(66946007)(66476007)(54906003)(956004)(2906002)(316002)(44832011)(33656002)(55016002)(8936002)(6496006)(81156014)(53546011)(508600001)(16526019)(26005)(4326008)(66556008)(6916009)(7416002)(33716001);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AWmZCS+NKiYOGroA7jUSb6s87vgIZ0aaItk44lifMsaGBozUD8TGsxZBRRd4kItGStvbnezJEiJBh5vt+5O4VCRCCYDIZ4/Mo97xjWcnu4fOMHiWpOpeTEqpXvHlinEkgS6UGOHjz+7FxBWOcTAh4t2+EQAHzLLaqpHiMAGpS6UTCR2vcQRYU3DEzEqeu8vS49HbAl/TV8LtP/K45OHYJ7uHK4BDYEbp1pGXNpxrE9mpSiykKUoftS2J+HHe5D/k3MmgZbY9ja/sxI66SxvSo5f1Yd+eD2Y0CRpsgjQ1SGfBeyiPYVLtfIUxtN7u7PxXniCZ8M/1d9nhc4J9fGpey6dcBNl20ff3Sd8w1aBewGBW1IEIC7YSqfvtpxf7ivqlVV4u/gG+VgAi2XYn5Sp/xx9fUwTzR/B3G1uLQSuq69+y2kPjEmw1ySX5cI+iBd+p
X-MS-Exchange-AntiSpam-MessageData: CGs9CA/GOqp59O0P6elyGOth+qaejZCNF3Gcpmg+l/vc/PYDIUeWoYniV84SmlBKUSqBO8GUJKtuajjHJ7n5YmGgXZbky2ry9ZzhMJ0wztr+Uuwa4+dK/4j+BoC0dddn18DIu0oe6S8OkQPxSxzmKw==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: 97a1b709-e73c-42eb-c306-08d7d54db049
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 08:29:54.4086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +cAhSLodrWa3NCov7Y/DuGHMWu2h8FIDXyjFQh8V4a96Zjle2Zrgjr900bqu8NTxgWTOC7MVeFp/EElijxjTod13AGZVKclS6O90VsJ1aoo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4474
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
> 
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> > 
> > Issue reported by coccinelle (coccicheck).
> > 
> > Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
>   ^ This should be dropped unless Quentin agrees to this version as well
> 
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> 
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> 
> -- 
> Stefano
> 

Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.

Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>

Thanks,
Quentin