Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3283802ybb; Tue, 31 Mar 2020 02:04:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuGJcsum47va7VblvcTRxvBf/TjH2q+ri05CoF5CJ1koQ4LLN8D1DcX4Y39R/65/CI3bkMD X-Received: by 2002:a9d:7c94:: with SMTP id q20mr10664309otn.150.1585645454328; Tue, 31 Mar 2020 02:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585645454; cv=none; d=google.com; s=arc-20160816; b=fzlWA4Im2IcaD7uI9YNbahapHs6vQmACPtw/pjxOzia5QvTuLopniN6UoefbaoDW7M mOtxgDSL0f6rNFXevlzDbKem854l5Pq+8CyDvU4iua/dN8bdIM+I1CDbQ0kVjqE1HSRs WNjcyL2y6dHEqnj5HkMDOMKFnkQpXLlUUA1/FMOz+ZmiNTKWWWyLgiuNW6ej788oB1Gs j3H0Ja1kpQ6TusgZ1yIginVUrslOVymxGgeoYc+tzf4So55W3neIM37sJCePxfa4XXXv Iw0iGXyb/A9Vwdi3c7I3QDLokmvpF06YCeLDVLkqhLyoZzt6jL7I5pZkAA3gzDuYIuzy yhAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=knZ+hug7+UK8D8eMK1PbFUi3cQwp+1hm/3edTqWRQsg=; b=ul7JGo4Oc5fzK93F04281OJGk+g715/5g8DDXiDKLhzi8KyOu5PhnDJU/I/ghj5zMI Ey5ELYKrj/TmYLBG8XTrs4SUGLHQoFYsgtRtWmXa/aBFQQIrrh25hLGUJuWCwnPImTzr pDwGiZ8h03D6BIxxPvwUbus+QwjJFlZTbPxYaDjmz//DR8gojXo6eB4d4uCw+wbwJCjp JRZ1RkPAQEz9g2xoJZHvlnq5plIpq/7cRG/GZw6zT3AwnkZgpfxz7Z3Eom4mFubvy4rw G43EMzc49XTfehTfaloBWV3lehNXmtxZv9cqbahKteFLO1RP1Q+SazrA6y+uyvU4OQL+ i0bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NQ2PVwv7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k70si7090790oih.24.2020.03.31.02.04.02; Tue, 31 Mar 2020 02:04:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NQ2PVwv7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730730AbgCaJCe (ORCPT + 99 others); Tue, 31 Mar 2020 05:02:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:42100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730489AbgCaJCc (ORCPT ); Tue, 31 Mar 2020 05:02:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BC88212CC; Tue, 31 Mar 2020 09:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585645351; bh=tofIbnmadnKlW1E9aujzGi22xYXbLQFA4YGG/fxn2lA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NQ2PVwv77DYq8TDh9f9tSWoBzr4KRV4Fdjqlm4D0vIx8ccGgtgQtFxWP7h+bWzA2f 8jJl3cTyMoDQi5eWiekSeFOiSGyqL3KzC0dk2bZM8PMITCLIWG96Z5qBI/5DZS0POY Jzd8vwvRrhb0KUSIQcnB8nAaSbNbBzkXRTpbnWuU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Naresh Kamboju , Anders Roxell , Faiz Abbas , Ulf Hansson , Sasha Levin Subject: [PATCH 5.5 004/170] mmc: sdhci-omap: Fix busy detection by enabling MMC_CAP_NEED_RSP_BUSY Date: Tue, 31 Mar 2020 10:56:58 +0200 Message-Id: <20200331085424.558492515@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200331085423.990189598@linuxfoundation.org> References: <20200331085423.990189598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ulf Hansson [ Upstream commit 055e04830d4544c57f2a5192a26c9e25915c29c0 ] It has turned out that the sdhci-omap controller requires the R1B response, for commands that has this response associated with them. So, converting from an R1B to an R1 response for a CMD6 for example, leads to problems with the HW busy detection support. Fix this by informing the mmc core about the requirement, via setting the host cap, MMC_CAP_NEED_RSP_BUSY. Reported-by: Naresh Kamboju Reported-by: Anders Roxell Reported-by: Faiz Abbas Cc: Tested-by: Anders Roxell Tested-by: Faiz Abbas Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/sdhci-omap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 083e7e053c954..d3135249b2e40 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -1134,6 +1134,9 @@ static int sdhci_omap_probe(struct platform_device *pdev) host->mmc_host_ops.execute_tuning = sdhci_omap_execute_tuning; host->mmc_host_ops.enable_sdio_irq = sdhci_omap_enable_sdio_irq; + /* R1B responses is required to properly manage HW busy detection. */ + mmc->caps |= MMC_CAP_NEED_RSP_BUSY; + ret = sdhci_setup_host(host); if (ret) goto err_put_sync; -- 2.20.1