Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932277AbWBXBBA (ORCPT ); Thu, 23 Feb 2006 20:01:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932269AbWBXBA7 (ORCPT ); Thu, 23 Feb 2006 20:00:59 -0500 Received: from smtp.osdl.org ([65.172.181.4]:27020 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932258AbWBXBA7 (ORCPT ); Thu, 23 Feb 2006 20:00:59 -0500 Date: Thu, 23 Feb 2006 16:59:59 -0800 From: Andrew Morton To: Christoph Lameter Cc: alokk@calsoftinc.com, manfred@colorfullife.com, penberg@gmail.com, linux-kernel@vger.kernel.org Subject: Re: Slab: Node rotor for freeing alien caches and remote per cpu pages. Message-Id: <20060223165959.7b4310e4.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 28 Christoph Lameter wrote: > > +void drain_node_pages(int nodeid) > { > - struct zone *zone; > - int i; > + int i, z; > unsigned long flags; > > local_irq_save(flags); > - for_each_zone(zone) { > + for (z = 0; z < MAX_NR_ZONES; z++) { > + struct zone *zone = NODE_DATA(nodeid)->node_zones + z; > struct per_cpu_pageset *pset; > > - /* Do not drain local pagesets */ > - if (zone->zone_pgdat->node_id == numa_node_id()) > - continue; > - > pset = zone_pcp(zone, smp_processor_id()); > for (i = 0; i < ARRAY_SIZE(pset->pcp); i++) { Should it be testing populated_zone() in there? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/